Support ContentNode.options when publishing.#1896
Merged
rtibbles merged 4 commits intolearningequality:hotfixesfrom Jun 26, 2020
Merged
Support ContentNode.options when publishing.#1896rtibbles merged 4 commits intolearningequality:hotfixesfrom
rtibbles merged 4 commits intolearningequality:hotfixesfrom
Conversation
9 tasks
jayoshih
previously requested changes
May 20, 2020
| license = models.ForeignKey('License', null=True, blank=True) | ||
|
|
||
| # A JSON Dictionary of properties to configure loading, rendering, etc. the file | ||
| options = JSONField(default={}) |
Contributor
There was a problem hiding this comment.
Noting that Kolibri uses a sqlite database, so not sure if this is compatible
Member
There was a problem hiding this comment.
It's using the jsonfield library JSONField which is what Kolibri uses too, so should be ok.
Codecov Report
@@ Coverage Diff @@
## hotfixes #1896 +/- ##
=========================================
Coverage 80.84% 80.84%
=========================================
Files 285 286 +1
Lines 12683 12693 +10
=========================================
+ Hits 10253 10262 +9
- Misses 2430 2431 +1
Continue to review full report at Codecov.
|
jayoshih
approved these changes
Jun 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One thing we have needed in Kolibri is a way to specify rendering and other display options for particular ContentNodes. A common example of this is when HTML5 content needs to render at a particular height and/or width.
There is a PR to add this on the Kolibri side (learningequality/kolibri#6873) but we also need to be able to export those options to the SQLite db as part of the publish operation. That is what this PR does. :)
Issue Addressed (if applicable)
Addresses #PR# HERE
Before/After Screenshots (if applicable)
Insert images here
Steps to Test
Implementation Notes (optional)
At a high level, how did you implement this?
Briefly describe how this works
Does this introduce any tech-debt items?
List anything that will need to be addressed later
Checklist
Delete any items that don't apply
docslabel been added if this introduces a change that needs to be updated in the user docs?CHANGELOGlabel been added to this pull request? Items with this label will be added to the CHANGELOG at a later timenotranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)?Comments
Any additional notes you'd like to add
Reviewers
If you are looking to assign a reviewer, here are some options: