Skip to content

Hide published status when showing sync progress#3717

Merged
rtibbles merged 1 commit intolearningequality:hotfixesfrom
bjester:sync-progress
Oct 6, 2022
Merged

Hide published status when showing sync progress#3717
rtibbles merged 1 commit intolearningequality:hotfixesfrom
bjester:sync-progress

Conversation

@bjester
Copy link
Copy Markdown
Member

@bjester bjester commented Oct 5, 2022

Summary

Description of the change(s) you made

  • Hides the channel's published status while showing the sync progress in the header
Before After
Screenshot from 2022-10-05 10-32-57 Screenshot from 2022-10-05 10-32-38

References

Refers #3710

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester bjester requested a review from rtibbles October 5, 2022 17:41
Copy link
Copy Markdown
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My channel was too small to see this happen in manual testing, but the code changes are very straight forward, and the screenshot removes all doubt!

@rtibbles rtibbles merged commit ed17889 into learningequality:hotfixes Oct 6, 2022
@bjester bjester mentioned this pull request Oct 17, 2022
@pcenov
Copy link
Copy Markdown
Member

pcenov commented Oct 20, 2022

@bjester is there anything that can be done so that the sync progress can be visible even for the smallest channel being synced? From a user point of view it still looks as though nothing is happening at all - perhaps there should be a text message similar to the one being displayed after successfully having published a channel - "Published 19 hours ago" - which can remain visible for some time.

@bjester
Copy link
Copy Markdown
Member Author

bjester commented Oct 20, 2022

@pcenov I added this issue for consideration from our design team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants