Skip to content

Fix for editing an exercise after adding a thumbnail #3353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sairina merged 1 commit into from
Mar 29, 2022
Merged

Fix for editing an exercise after adding a thumbnail #3353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions contentcuration/contentcuration/frontend/channelEdit/vuex/contentNode/getters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,16 +133,17 @@ export function getContentNodeDetailsAreValid(state) {
export function getContentNodeFilesAreValid(state, getters, rootState, rootGetters) {
return function(contentNodeId) {
const contentNode = state.contentNodesMap[contentNodeId];
if (
contentNode.kind === ContentKindsNames.TOPIC ||
contentNode.kind === ContentKindsNames.EXERCISE
) {
return true;
}
if (contentNode && contentNode.kind !== ContentKindsNames.TOPIC) {
let files = rootGetters['file/getContentNodeFiles'](contentNode.id);
if (files.length) {
// Don't count errors before files have loaded
return !getNodeFilesErrors(files).length;
} else if (
contentNode.kind === ContentKindsNames.TOPIC ||
contentNode.kind === ContentKindsNames.EXERCISE
) {
return true;
} else {
return false;
}
Expand Down