Fix for editing an exercise after adding a thumbnail#3353
Merged
sairina merged 1 commit intolearningequality:unstablefrom Mar 29, 2022
d0sadata:thumbnail-issues
Merged
Fix for editing an exercise after adding a thumbnail#3353sairina merged 1 commit intolearningequality:unstablefrom d0sadata:thumbnail-issues
sairina merged 1 commit intolearningequality:unstablefrom
d0sadata:thumbnail-issues
Conversation
switched if check order.
Contributor
|
@pcenov, this PR seems to fix the issue you described in #3158 ; however, I noticed that there's a follow-up problem (not necessarily related to this fix) where if a user then deletes the thumbnail and saves/clicks on "Finish", when the user is back on the channel editing page, the thumbnail that was deleted is still there. Would you mind checking to see if this is an issue, as well? |
sairina
approved these changes
Mar 28, 2022
Contributor
sairina
left a comment
There was a problem hiding this comment.
lgtm - this change fixes the reported issue.
MisRob
approved these changes
Mar 29, 2022
This was referenced Sep 15, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #3158
The issue was a check order that wasn't executed properly, Misha helped me find it and solve it.
the order now first checks if the validation for file upload is required for exerice files or not.
Manual verification steps performed
Reviewer guidance
Same as the issue reporting, create a new Exercise,
Add a thumbnail
Go to save
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)