Skip to content

Copy translations for close button label#3135

Merged
bjester merged 1 commit intolearningequality:hotfixesfrom
bjester:close-button-translation
May 5, 2021
Merged

Copy translations for close button label#3135
bjester merged 1 commit intolearningequality:hotfixesfrom
bjester:close-button-translation

Conversation

@bjester
Copy link
Copy Markdown
Member

@bjester bjester commented May 4, 2021

Summary

Description of the change(s) you made

Copies existing translations for new "Close" button label

References

Resolves: #3122

Comments


Contributor's Checklist

Studio-specifc:

  • All user-facing strings are translated properly

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Copy Markdown
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏽

@bjester bjester merged commit 6be5e2f into learningequality:hotfixes May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New/updated strings are translated in hotfixes

2 participants