Skip to content

Fix PostgreSQL 18 build failure in ambulkdelete #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
siddiqueirshad wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix PostgreSQL 18 build failure in ambulkdelete #378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lantern_hnsw/src/hnsw/delete.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,15 @@
#include "hnsw/utils.h"
#include "usearch_storage.hpp"

/*
* PostgreSQL 18 changed vacuum_delay_point() to take an is_analyze argument
* (postgres commit e5b0b0c). Index vacuum paths are not analyze, so pass false.
* Keep the zero-arg call on older majors via this compatibility shim.
*/
#if PG_VERSION_NUM >= 180000
#define vacuum_delay_point() vacuum_delay_point(false)
#endif

IndexBulkDeleteResult *ldb_ambulkdelete(IndexVacuumInfo *info,
IndexBulkDeleteResult *stats,
IndexBulkDeleteCallback callback,
Expand Down