Repository navigation
Fix PostgreSQL 18 build failure in ambulkdelete - #378
Open
siddiqueirshad wants to merge 1 commit into
Open
siddiqueirshad wants to merge 1 commit into
siddiqueirshad wants to merge 1 commit into
Conversation
PostgreSQL 18 requires vacuum_delay_point(bool is_analyze). Pass false from the index vacuum path via a version-gated compatibility shim so older majors keep the zero-argument call. Fixes lanterndata#375. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Hi @Ngalstyan4, when you get a chance, could you please take a look at this PR? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vacuum_delay_point()now requires abool is_analyzeargument (postgres commit e5b0b0c).ldb_ambulkdelete()that expands tovacuum_delay_point(false)on PG 18+, matching the established approach used by pgvector for the same API change.Root cause
PostgreSQL 18 changed
vacuum_delay_pointfromvoid vacuum_delay_point(void)tovoid vacuum_delay_point(bool is_analyze). Lantern's index vacuum path inlantern_hnsw/src/hnsw/delete.cstill used the zero-argument form, so builds against PG 18 headers fail withtoo few arguments to function call.Test plan
REL_18_STABLEdeclaresvacuum_delay_point(bool is_analyze)andREL_17_STABLEstill declares the zero-arg form#if PG_VERSION_NUM >= 180000)Fixes #375