Skip to content

fix(web): open embedded recommend banner plugins in the detail dialog - #41899

Merged
CodingOnStar merged 1 commit into
hotfix/1.17.0-fix.14from
cherry-pick/hotfix-1.17.0-fix.14-recommend-banner
Sep 7, 2026
Merged

CodingOnStar merged 1 commit into
hotfix/1.17.0-fix.14from
cherry-pick/hotfix-1.17.0-fix.14-recommend-banner

Conversation

@CodingOnStar

Copy link
Copy Markdown
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Cherry-pick of #41828 onto hotfix/1.17.0-fix.14.

Follow-up to #41538. In the in-app marketplace, clicking a plugin on a recommend banner now opens the same MarketplaceDetailDialog as homepage plugin cards. The standalone marketplace still navigates to the plugin detail page.

Related marketplace submodule bump: langgenius/dify-marketplace#163.

Screenshots

N/A — click-target change covered by unit tests.

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and vp staged (frontend) to appease the lint gods

@github-actions github-actions Bot added the web This relates to changes on the web. label Sep 7, 2026
…#41828)

Co-authored-by: fatelei <fatelei@gmail.com>
Co-authored-by: zxhlyh <jasonapring2015@outlook.com>
Co-authored-by: CodingOnStar <hanxujiang@dify.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: 姜涵煦 <hanxujiang@jianghanxudeMacBook-Pro-2.local>
Co-authored-by: L1nSn0w <l1nsn0w@qq.com>
Co-authored-by: yyh <92089059+lyzno1@users.noreply.github.com>

(cherry picked from commit 762dc5e)
@CodingOnStar
CodingOnStar force-pushed the cherry-pick/hotfix-1.17.0-fix.14-recommend-banner branch from 13af121 to 2dfb625 Compare September 7, 2026 03:47

@lin-snow lin-snow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodingOnStar
CodingOnStar merged commit 70464bd into hotfix/1.17.0-fix.14 Sep 7, 2026
3 checks passed
@CodingOnStar
CodingOnStar deleted the cherry-pick/hotfix-1.17.0-fix.14-recommend-banner branch September 7, 2026 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants