fix(web): open embedded recommend banner plugins in the detail dialog by CodingOnStar · Pull Request #41828 · langgenius/dify

CodingOnStar · 2026-09-04T11:30:56Z

Important

Make sure you have read our contribution guidelines
Ensure there is an associated issue and you have been assigned to it
Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Follow-up to #41538. In the in-app marketplace, clicking a plugin on a recommend banner now opens the same MarketplaceDetailDialog as homepage plugin cards. The standalone marketplace still navigates to the plugin detail page.

Related marketplace submodule bump: langgenius/dify-marketplace#163.

Screenshots

N/A — click-target change covered by unit tests.

Checklist

This change requires a documentation update, included: Dify Document
I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
I've updated the documentation accordingly.
I ran make lint && make type-check (backend) and vp staged (frontend) to appease the lint gods

# Conflicts: # oxlint-suppressions.json # packages/contracts/marketplace.ts # web/app/(commonLayout)/marketplace/page.tsx # web/app/components/main-nav/routes.ts # web/app/components/plugins/marketplace/detail-dialog/__tests__/index.spec.tsx # web/app/components/plugins/marketplace/detail-dialog/index.tsx # web/app/components/plugins/marketplace/home/__tests__/home-catalog-navigation.spec.tsx # web/app/components/plugins/marketplace/home/__tests__/home-header.spec.tsx # web/app/components/plugins/marketplace/home/__tests__/home-trending.spec.tsx # web/app/components/plugins/marketplace/home/home-catalog-tabs.tsx # web/app/components/plugins/marketplace/home/home-header.tsx # web/app/components/plugins/marketplace/home/home-search.tsx # web/app/components/plugins/marketplace/home/home-trending.tsx # web/app/components/plugins/marketplace/home/index.tsx # web/app/components/plugins/marketplace/index.tsx # web/app/components/plugins/marketplace/list/__tests__/card-wrapper.spec.tsx # web/app/components/plugins/marketplace/list/list-wrapper.tsx # web/app/components/plugins/marketplace/view.tsx

Independent Marketplace does not load the tools namespace, so tools.author fell back to the key "author". Use plugin.marketplace.by.

…hor fixes

Keep marketplace.creatorProfile.loadMore and loadMoreFailed from falling back to English in non-en locales. Dutch by-author copy is Door.

…home # Conflicts: # web/app/components/plugins/marketplace/list/__tests__/list-with-collection.spec.tsx # web/app/components/plugins/marketplace/list/carousel.tsx # web/app/components/plugins/marketplace/list/list-with-collection.tsx

CI Style Check / TS Common failed on vp check formatting for this file.

Console Docker keeps MARKETPLACE_API_URL as the marketplace origin and entrypoint derives NEXT_PUBLIC_MARKETPLACE_API_PREFIX with /api/v1. SSR preferred the bare origin, so /templates hit HTML instead of the API and showed marketplace.loadError on staging.

# Conflicts: # web/__tests__/proxy-frame-options.spec.ts # web/config/index.ts # web/i18n/ar-TN/plugin.json # web/i18n/de-DE/common.json # web/i18n/de-DE/plugin.json # web/i18n/es-ES/plugin.json # web/i18n/fa-IR/plugin.json # web/i18n/fr-FR/plugin.json # web/i18n/hi-IN/plugin.json # web/i18n/id-ID/plugin.json # web/i18n/it-IT/plugin.json # web/i18n/ko-KR/plugin.json # web/i18n/lo-LA/plugin.json # web/i18n/nl-NL/plugin.json # web/i18n/pl-PL/plugin.json # web/i18n/ro-RO/plugin.json # web/i18n/ru-RU/plugin.json # web/i18n/sl-SI/plugin.json # web/i18n/th-TH/plugin.json # web/i18n/tr-TR/plugin.json # web/i18n/uk-UA/plugin.json # web/i18n/vi-VN/plugin.json

In-app marketplace recommend cards now reuse the plugin tab dialog instead of navigating away. The standalone marketplace still routes to the plugin page.

codecov · 2026-09-05T03:08:44Z

Codecov Report

❌ Patch coverage is 98.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.14%. Comparing base (d93e5aa) to head (fa0e135).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
.../plugins/marketplace/home/home-trending-slides.tsx	98.03%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #41828   +/-   ##
=======================================
  Coverage   87.13%   87.14%           
=======================================
  Files        5413     5413           
  Lines      311849   311899   +50     
  Branches    62656    62652    -4     
=======================================
+ Hits       271732   271790   +58     
+ Misses      34806    34798    -8     
  Partials     5311     5311

Flag	Coverage Δ
dify-ui	`93.74% <ø> (ø)`
web	`87.35% <98.33%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…#41828) Co-authored-by: fatelei <fatelei@gmail.com> Co-authored-by: zxhlyh <jasonapring2015@outlook.com> Co-authored-by: CodingOnStar <hanxujiang@dify.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: 姜涵煦 <hanxujiang@jianghanxudeMacBook-Pro-2.local> Co-authored-by: L1nSn0w <l1nsn0w@qq.com> Co-authored-by: yyh <92089059+lyzno1@users.noreply.github.com> (cherry picked from commit 762dc5e)

fatelei and others added 30 commits August 11, 2026 07:24

fix: fix publish

eef27df

Merge branch 'skill' into deploy/dev

b1249df

fix(skills): preserve markdown editor position

98ff51d

fix: fix agent delete not update skill ref

e6bf7d3

Merge branch 'skill' into deploy/dev

0958b12

fix(skills): align tag selector interactions

f237392

fix(skills): localize published status

202f650

fix: fix agent read wrong skill name and description

1799683

Merge branch 'skill' into deploy/dev

a5d8af2

feat: add permission ui check

c7ae155

fix: fix scroll

6e4893f

feat: add permission ui check

a87e396

fix: fix scroll

f3df36a

chore: add miss file

080a09b

Merge branch 'skill' into deploy/dev

7d2a377

fix(skills): avoid duplicate publish errors

615628e

fix: fix permission

d95049c

Merge branch 'skill' into deploy/dev

330288b

fix(skills): reload latest draft after conflicts

c440fa1

fix: fix skill name not refresh

953b264

Merge branch 'skill' into deploy/dev

33e5b84

fix: fix agent pull skill name wrong

37510f5

Merge branch 'skill' into deploy/dev

e1bacf0

fix(web): prevent duplicate oauth authorization

3094a00

fix(skills): align markdown placeholder with caret

01552e0

Merge branch 'skill' into deploy/dev

685f611

fix(web): resolve deploy build regressions

e91a8ed

feat: redesign marketplace homepage

270568f

fix: align marketplace homepage with standalone design

8bff4ad

CodingOnStar added 9 commits September 4, 2026 15:25

fix(web): show by-author copy on marketplace plugin cards

b26545b

Independent Marketplace does not load the tools namespace, so tools.author fell back to the key "author". Use plugin.marketplace.by.

merge: bring origin/feat/creator-profile-home into query() and by-aut…

0d8d80e

…hor fixes

fix(web): translate creator profile load-more copy

c0234c8

Keep marketplace.creatorProfile.loadMore and loadMoreFailed from falling back to English in non-en locales. Dutch by-author copy is Door.

style(web): format marketplace card by-author spec

a170e6b

CI Style Check / TS Common failed on vp check formatting for this file.

merge: bring origin/main into feat/creator-profile-home

d0052be

fix(web): open embedded recommend banner plugins in the detail dialog

a1cf6b2

In-app marketplace recommend cards now reuse the plugin tab dialog instead of navigating away. The standalone marketplace still routes to the plugin page.

CodingOnStar requested review from Yessenia-d, iamjoel and lyzno1 as code owners September 4, 2026 11:30

github-actions Bot added the web This relates to changes on the web. label Sep 4, 2026

CodingOnStar and others added 5 commits September 4, 2026 19:31

Merge branch 'main' into feat/creator-profile-home

b8cd081

fix: restore marketplace collections after clearing category

76cc05a

fix: make marketplace search cards responsive

9a8c457

fix: support dotenv and unknown markdown code languages

7820a18

merge: sync remote creator profile branch before publishing

fa0e135

CodingOnStar requested review from hyoban and zxhlyh as code owners September 5, 2026 03:05

MRZHUH approved these changes Sep 7, 2026

View reviewed changes

CodingOnStar added this pull request to the merge queue Sep 7, 2026

Merged via the queue into main with commit 762dc5e Sep 7, 2026
51 checks passed

CodingOnStar deleted the feat/creator-profile-home branch September 7, 2026 03:27

CodingOnStar mentioned this pull request Sep 7, 2026

fix(web): open embedded recommend banner plugins in the detail dialog #41899

Merged

2 of 5 tasks

hyoban mentioned this pull request Oct 22, 2026

refactor(web): highlight markdown code blocks with @pierre/highlights #44522

Merged

3 of 5 tasks

Navigation Menu

Repository navigation

fix(web): open embedded recommend banner plugins in the detail dialog - #41828

fix(web): open embedded recommend banner plugins in the detail dialog#41828
CodingOnStar merged 686 commits into
mainfrom
feat/creator-profile-home

CodingOnStar commented Sep 4, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Sep 5, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

CodingOnStar commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Screenshots

Checklist

Uh oh!

codecov Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

CodingOnStar commented Sep 4, 2026 •

edited

Loading

codecov Bot commented Sep 5, 2026 •

edited

Loading