Repository navigation
refactor: add @override decorators to storage backend subclasses (#36406) - #36755
Merged
asukaminato0721 merged 1 commit intoMay 28, 2026
Conversation
…ggenius#36406) Covers the 12 BaseStorage subclasses under extensions/storage/: aliyun, aws_s3, azure_blob, baidu_obs, clickzetta_volume, google_cloud, huawei_obs, opendal, oracle_oci, supabase, tencent_cos, volcengine_tos.
dosubot
Bot
added
size:M
asukaminato0721
approved these changes
May 28, 2026
asukaminato0721
enabled auto-merge
May 28, 2026 05:51
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-05-28 05:52:10.543710141 +0000
+++ /tmp/pyrefly_pr.txt 2026-05-28 05:51:57.051672084 +0000
@@ -85,9 +85,9 @@
ERROR Cannot set item in `dict[str, dict[str, crontab | str]]` [unsupported-operation]
--> extensions/ext_celery.py:246:61
ERROR Cannot index into `Literal['']` [bad-index]
- --> extensions/storage/huawei_obs_storage.py:27:23
+ --> extensions/storage/huawei_obs_storage.py:30:23
ERROR Cannot index into `Literal['']` [bad-index]
- --> extensions/storage/huawei_obs_storage.py:31:20
+ --> extensions/storage/huawei_obs_storage.py:35:20
ERROR Argument `Module[Crypto.Hash.SHA1] | Unknown` is not assignable to parameter with type `Hash | HashModule` [bad-argument-type]
--> libs/gmpy2_pkcs10aep_cipher.py:73:49
ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `dify_vdb_alibabacloud_mysql.alibabacloud_mysql_vector.AlibabaCloudMySQLVectorFactory.init_vector` [bad-argument-type]
|
Contributor
Pyrefly Type Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds `@override` decorators (from `typing.override`, per Python 3.12 target) to the `BaseStorage` subclasses under `api/extensions/storage/`. This is one of the still-uncovered class hierarchies for #36406.
74 method overrides decorated across 12 backends:
Pure additive change — runtime behaviour is unchanged.
Closes part of #36406.
```
$ uvx ruff check api/extensions/storage/
All checks passed!
$ uvx ruff format --check api/extensions/storage/
17 files already formatted
```