Skip to content

[Refactor/Chore] add missing-override-decorator #36406

Closed
Closed
[Refactor/Chore] add missing-override-decorator#36406
Assignees
AlsoTheZv3nQuantum0uasar
Labels
good first issueGood first issue for newcomersstatus: accepting prsGo ahead, send a pull request that resolves this issue

Description

@asukaminato0721
asukaminato0721
opened on May 19, 2026

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for refactors or chores; if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Description

these missing override ERROR Class member `RemoteSettingsSourceFactory.get_field_value` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DifyConfig.settings_customise_sources` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ApolloSettingsSource.get_field_value` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `NacosSettingsSource.get_field_value` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `NullAppContext.get_config` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `NullAppContext.get_extension` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `NullAppContext.enter` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `FlaskAppContext.get_config` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `FlaskAppContext.get_extension` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `FlaskAppContext.enter` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowRunStatusField.output` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowRunOutputsField.output` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `CotChatAgentRunner._organize_prompt_messages` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `CotCompletionAgentRunner._organize_prompt_messages` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginAgentStrategy.get_parameters` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginAgentStrategy._invoke` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `AdvancedChatAppGenerateResponseConverter.convert_blocking_full_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `AdvancedChatAppGenerateResponseConverter.convert_blocking_simple_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `AdvancedChatAppGenerateResponseConverter.convert_stream_full_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `AdvancedChatAppGenerateResponseConverter.convert_stream_simple_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `AgentChatAppGenerateResponseConverter.convert_blocking_full_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `AgentChatAppGenerateResponseConverter.convert_blocking_simple_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `AgentChatAppGenerateResponseConverter.convert_stream_full_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `AgentChatAppGenerateResponseConverter.convert_stream_simple_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ChatAppGenerateResponseConverter.convert_blocking_full_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ChatAppGenerateResponseConverter.convert_blocking_simple_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ChatAppGenerateResponseConverter.convert_stream_full_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ChatAppGenerateResponseConverter.convert_stream_simple_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `CompletionAppGenerateResponseConverter.convert_blocking_full_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `CompletionAppGenerateResponseConverter.convert_blocking_simple_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `CompletionAppGenerateResponseConverter.convert_stream_full_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `CompletionAppGenerateResponseConverter.convert_stream_simple_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `NoopDraftVariableSaver.save` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `MessageBasedAppQueueManager._publish` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowAppGenerateResponseConverter.convert_blocking_full_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowAppGenerateResponseConverter.convert_blocking_simple_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowAppGenerateResponseConverter.convert_stream_full_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowAppGenerateResponseConverter.convert_stream_simple_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PipelineQueueManager._publish` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowAppQueueManager._publish` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowAppGenerateResponseConverter.convert_blocking_full_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowAppGenerateResponseConverter.convert_blocking_simple_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowAppGenerateResponseConverter.convert_stream_full_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowAppGenerateResponseConverter.convert_stream_simple_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DatabaseFileAccessController.current_scope` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DatabaseFileAccessController.apply_upload_file_filters` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DatabaseFileAccessController.apply_tool_file_filters` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DatabaseFileAccessController.get_upload_file` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DatabaseFileAccessController.get_tool_file` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ConversationVariablePersistenceLayer.on_graph_start` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ConversationVariablePersistenceLayer.on_event` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ConversationVariablePersistenceLayer.on_graph_end` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PauseStatePersistenceLayer.on_graph_start` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PauseStatePersistenceLayer.on_event` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PauseStatePersistenceLayer.on_graph_end` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `SuspendLayer.on_graph_start` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `SuspendLayer.on_event` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `SuspendLayer.on_graph_end` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `TimeSliceLayer.on_graph_start` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `TimeSliceLayer.on_event` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `TimeSliceLayer.on_graph_end` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `TriggerPostLayer.on_graph_start` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `TriggerPostLayer.on_event` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `TriggerPostLayer.on_graph_end` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DifyWorkflowFileRuntime.multimodal_send_format` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DifyWorkflowFileRuntime.http_get` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DifyWorkflowFileRuntime.storage_load` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DifyWorkflowFileRuntime.load_file_bytes` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DifyWorkflowFileRuntime.resolve_file_url` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DifyWorkflowFileRuntime.resolve_upload_file_url` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DifyWorkflowFileRuntime.resolve_tool_file_url` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DifyWorkflowFileRuntime.verify_preview_signature` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowPersistenceLayer.on_graph_start` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowPersistenceLayer.on_event` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowPersistenceLayer.on_graph_end` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `LocalFileDatasourcePlugin.datasource_provider_type` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `LocalFileDatasourcePlugin.get_icon_url` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `LocalFileDatasourcePluginProviderController.provider_type` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `LocalFileDatasourcePluginProviderController._validate_credentials` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `OnlineDocumentDatasourcePlugin.datasource_provider_type` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `OnlineDocumentDatasourcePluginProviderController.provider_type` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `OnlineDriveDatasourcePlugin.datasource_provider_type` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `OnlineDriveDatasourcePluginProviderController.provider_type` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WebsiteCrawlDatasourcePlugin.datasource_provider_type` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WebsiteCrawlDatasourcePluginProviderController.provider_type` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ProviderConfigurations.__iter__` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ApiExternalDataTool.validate_config` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ApiExternalDataTool.query` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `JavascriptCodeProvider.get_language` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `JavascriptCodeProvider.get_default_code` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `NodeJsTemplateTransformer.get_runner_script` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Jinja2TemplateTransformer.transform_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Jinja2TemplateTransformer.assemble_runner_script` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Jinja2TemplateTransformer.get_runner_script` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Jinja2TemplateTransformer.get_preload_script` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Python3CodeProvider.get_language` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Python3CodeProvider.get_default_code` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Python3TemplateTransformer.get_runner_script` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `SingletonProviderCredentialsCache._generate_cache_key` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ToolProviderCredentialsCache._generate_cache_key` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `TraceContextFilter.filter` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `IdentityContextFilter.filter` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `StructuredJSONFormatter.format` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `MCPClientWithAuthRetry.__enter__` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `MCPClientWithAuthRetry.list_tools` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `MCPClientWithAuthRetry.invoke_tool` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ClientSession.send_progress_notification` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ClientSession._received_request` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ClientSession._handle_incoming` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ClientSession._received_notification` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ApiModeration.validate_config` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ApiModeration.moderation_for_inputs` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ApiModeration.moderation_for_outputs` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `KeywordsModeration.validate_config` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `KeywordsModeration.moderation_for_inputs` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `KeywordsModeration.moderation_for_outputs` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `OpenAIModeration.validate_config` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `OpenAIModeration.moderation_for_inputs` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `OpenAIModeration.moderation_for_outputs` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginDaemonError.__str__` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.fetch_model_providers` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.get_provider_icon` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.validate_provider_credentials` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.validate_model_credentials` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.get_model_schema` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.invoke_llm` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.invoke_llm_with_structured_output` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.get_llm_num_tokens` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.invoke_text_embedding` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.invoke_multimodal_embedding` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.get_text_embedding_num_tokens` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.invoke_rerank` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.invoke_multimodal_rerank` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.invoke_tts` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.get_tts_model_voices` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.invoke_speech_to_text` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.invoke_moderation` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Jieba.create` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Jieba.add_texts` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Jieba.text_exists` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Jieba.delete_by_ids` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Jieba.search` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Jieba.delete` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `_LazyEmbeddings.embed_documents` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `_LazyEmbeddings.embed_multimodal_documents` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `_LazyEmbeddings.embed_query` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `_LazyEmbeddings.embed_multimodal_query` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `_LazyEmbeddings.aembed_documents` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ...

you can use pyrefly check strict to find them.

Motivation

https://peps.python.org/pep-0698/

Additional Context

No response

Activity

  1. asukaminato0721
    added
    good first issueGood first issue for newcomers
    status: accepting prsGo ahead, send a pull request that resolves this issue
    on May 19, 2026

  2. asukaminato0721 commented on May 19, 2026

    @asukaminato0721
    asukaminato0721
    on May 19, 2026
    ContributorAuthor

    @dosu how to fix this

  3. dosubot commented on May 19, 2026

    @dosubot
    dosubotBot
    on May 19, 2026 – with DosuBot

    To fix these missing @override decorator errors, add the @override decorator to each overriding method. Here's what to do:

    1. Add the import at the top of each affected file:

    from typing_extensions import override

    This is the pattern most commonly used in the Dify codebase [1] since the project targets Python 3.12 [2], which predates typing.override (added in 3.13).

    2. Decorate each overriding method with @override:

    from typing_extensions import override

class MySubclass(ParentClass):
    @override
    def some_method(self):
        ...

    For properties, place @override below @property:

    @property
@override
def provider(self) -> SomeType:
    ...

    For class methods, place @override below @classmethod [3]:

    @classmethod
@override
def from_config(cls, config: Config) -> Self:
    ...

    3. Apply systematically. Given the ~100+ violations, you could script this or handle it file-by-file. A quick approach:

    • Use pyrefly check strict (as you mentioned) to get the full list
    • For each class/method pair, add from typing_extensions import override to the file's imports (if not already present) and place @override on the method

    The fix is purely additive — it doesn't change runtime behavior, just improves type-safety by ensuring the type checker verifies that the method actually overrides a parent method (per PEP 698).

    To reply, just mention @dosu.

    Share context across your team and agents. Try Dosu.

    Leave Feedback Learn about dify with Dosu

  4. asukaminato0721 commented on May 19, 2026

    @asukaminato0721
    asukaminato0721
    on May 19, 2026
    ContributorAuthor

    @dosu no, https://docs.python.org/3/library/typing.html#typing.override

    it's from 3.12

  5. dosubot commented on May 19, 2026

    @dosubot
    dosubotBot
    on May 19, 2026 – with DosuBot

    You're right, my mistake — typing.override was added in Python 3.12 (PEP 698). Since Dify already targets Python 3.12, you can import directly from the standard library:

    from typing import override

    No need for typing_extensions. The fix remains the same otherwise — add @override to each overriding method listed in the errors. Thanks for the correction!

    To reply, just mention @dosu.

    Share context across your team and agents. Try Dosu.

    Leave Feedback Learn about dify with Dosu

  6. wingwkyuen
    added a commit that references this issue on May 20, 2026

    chore: example for [Refactor/Chore] add missing-override-decorator la…

    de38bba

  7. Quantum0uasar commented on May 21, 2026

    @Quantum0uasar
    Quantum0uasar
    on May 21, 2026

    Hi! I'd like to contribute to this refactoring effort.

    I'll scan the codebase for methods that override parent class methods but are missing the @override decorator (using typing.override from Python 3.12+). I'll submit a PR covering a batch of files.

    I'll follow the pattern from the example in #36425. Will open a draft PR soon!

  8. asukaminato0721
    assigned
    Quantum0uasar
    on May 21, 2026

  9. AlsoTheZv3n commented on May 21, 2026

    @AlsoTheZv3n
    AlsoTheZv3n
    on May 21, 2026
    Contributor

    Hi @Quantum0uasar — happy to help split the load on this one. To avoid overlap, I'm planning a focused PR scoped to the five *AppGenerateResponseConverter classes under api/core/app/apps/{advanced_chat,agent_chat,chat,completion,workflow}/generate_response_converter.py (the 20 convert_blocking_full_response / convert_blocking_simple_response / convert_stream_full_response / convert_stream_simple_response errors in that group). Let me know if you'd rather take those yourself and I'll pick a different slice — otherwise I'll open the PR shortly.

  10. asukaminato0721
    assigned
    AlsoTheZv3n
    on May 21, 2026

  11. AlsoTheZv3n commented on May 22, 2026

    @AlsoTheZv3n
    AlsoTheZv3n
    on May 22, 2026
    Contributor

    Hi @asukaminato0721 — re: enabling the flag.

    All the errors originally listed in the issue body are fixed across PRs #36486, #36490, #36491, #36492, #36493, #36494, #36495, #36496, #36511, and #36528.

    Before opening the config PR I ran pyrefly check on current main to confirm. It still surfaces 756 missing-override-decorator errors across 252 files, distributed as:

    Dir Errors
    tests/ 243
    core/ 188
    extensions/ 96
    repositories/ 55
    services/ 49
    providers/ 47
    libs/ 37
    models/ 26
    other ~15

    The original issue body was truncated (the error listing ended with ...), so these weren't part of the initial scope. Enabling the flag now would fail CI on ~756 errors.

    Happy to keep chipping away in similarly-scoped batches if that's the preferred path. Some questions before I do:

    1. Should tests/ be excluded (243 of the 756 are in test files)?
    2. Any preferred batching order (largest offenders first, or by module)?
    3. Would a separate tracking issue help, or is [Refactor/Chore] add missing-override-decorator #36406 fine as the umbrella?

  12. tayyub-ai commented on May 27, 2026

    @tayyub-ai
    tayyub-ai
    on May 27, 2026

    Hi, happy to help. To avoid overlap with @AlsoTheZv3n 's batches, I'll pick the api/models/ slice (≈26 errors). Will open a PR shortly. Tag me if anyone has already started.

  13. Quantum0uasar commented on May 27, 2026

    @Quantum0uasar
    Quantum0uasar
    on May 27, 2026

    To avoid overlap with @tayyub-ai's api/models/ batch, I'll take the api/services/ slice. Will open a PR shortly — tag me if that directory has already been claimed.

  14. NishchayMahor
    added a commit that references this issue on May 28, 2026

    refactor: add @OverRide decorators to storage backend subclasses (lan…

    2f034c1
  15. pull
    added a commit that references this issue on May 28, 2026

    refactor: add @OverRide decorators to storage backend subclasses (lan…

    57b02e3

  16. eryue0220 commented on May 28, 2026

    @eryue0220
    eryue0220
    on May 28, 2026
    Contributor

    I‘ll take the api/extensions/ slice, and I'll open a PR shortly — tag me if that directory has already been claimed.

  17. siyux1927 commented on Jun 3, 2026

    @siyux1927
    siyux1927
    on Jun 3, 2026
    Contributor

    Taking api/configs/app_config.py (RemoteSettingsSourceFactory.call).

  18. siyux1927 commented on Jun 3, 2026

    @siyux1927
    siyux1927
    on Jun 3, 2026
    Contributor

    Hi. Taking api/core/rag/extractor/ (all *Extractor.extract() overrides).

  19. asukaminato0721
    closed this as completedon Jun 8, 2026
  20. WH-2099
    added a commit that references this issue on Jun 18, 2026

    refactor: add missing @OverRide decorators to method overrides

    bd23051
  21. Ssazurov
    added 2 commits that reference this issue on Aug 8, 2026

    chore: example for [Refactor/Chore] add missing-override-decorator la…

    10a1623

    refactor: add @OverRide decorators to storage backend subclasses (lan…

    0734c82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

good first issueGood first issue for newcomersstatus: accepting prsGo ahead, send a pull request that resolves this issue

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions