Repository navigation
chore: example for [Refactor/Chore] add missing-override-decorator #36406 - #36425
Merged
Merged
Conversation
asukaminato0721
enabled auto-merge
May 20, 2026 05:41
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #36406 by adding missing @override decorators to methods that override parent-class members, aligning the codebase with the missing-override-decorator lint rule.
Changes:
- Added
typing.overrideimport and applied@overridetoRemoteSettingsSourceFactory.get_field_value. - Applied
@overridetoDifyConfig.settings_customise_sources.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Pyrefly Type Coverage
|
WH-2099
approved these changes
May 20, 2026
zhangtaodemama
added a commit
to zhangtaodemama/langgenius-dify-bfaadcb0c706
that referenced
this pull request
May 20, 2026
6 tasks done
This was referenced May 21, 2026
refactor: add missing @override decorator to file access controller and workflow file runtime
#36495
Merged
Ssazurov
pushed a commit
to Ssazurov/dify
that referenced
this pull request
Aug 8, 2026
…nggenius#36406 (langgenius#36425) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
#36406
Screenshots
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint gods