Skip to content

chore: example for [Refactor/Chore] add missing-override-decorator #36406 - #36425

Merged
asukaminato0721 merged 2 commits into
langgenius:mainfrom
asukaminato0721:36406
May 20, 2026
Merged

asukaminato0721 merged 2 commits into
langgenius:mainfrom
asukaminato0721:36406

Conversation

@asukaminato0721

@asukaminato0721 asukaminato0721 commented May 20, 2026 •

Copy link
Copy Markdown
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

#36406

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

Copilot AI review requested due to automatic review settings May 20, 2026 05:41
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. refactor labels May 20, 2026
@asukaminato0721
asukaminato0721 enabled auto-merge May 20, 2026 05:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #36406 by adding missing @override decorators to methods that override parent-class members, aligning the codebase with the missing-override-decorator lint rule.

Changes:

  • Added typing.override import and applied @override to RemoteSettingsSourceFactory.get_field_value.
  • Applied @override to DifyConfig.settings_customise_sources.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread api/configs/app_config.py Outdated
Comment thread api/configs/app_config.py
@github-actions

Copy link
Copy Markdown
Contributor

Pyrefly Type Coverage

Metric Base PR Delta
Type coverage 0.00% 44.50% +44.50%
Strict coverage 0.00% 44.02% +44.02%
Typed symbols 0 22,758 +22,758
Untyped symbols 0 28,692 +28,692
Modules 0 2598 +2,598

@asukaminato0721
asukaminato0721 added this pull request to the merge queue May 20, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 20, 2026
Merged via the queue into langgenius:main with commit de38bba May 20, 2026
27 checks passed
@asukaminato0721
asukaminato0721 deleted the 36406 branch May 20, 2026 06:30
zhangtaodemama added a commit to zhangtaodemama/langgenius-dify-bfaadcb0c706 that referenced this pull request May 20, 2026
Ssazurov pushed a commit to Ssazurov/dify that referenced this pull request Aug 8, 2026
…nggenius#36406 (langgenius#36425)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer refactor size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants