fix(test): extend timeout for ripgrep tests that download the rg binary (LAC-2693)#35
Open
lacymorrow wants to merge 1 commit into
Conversation
…ry (LAC-2693) On Windows CI runners the first Ripgrep.Service use downloads the rg release zip and extracts it via PowerShell Expand-Archive, which exceeds bun's default 5s per-test timeout. The test SIGTERMs the extraction mid-flight, nothing is cached, and all four ripgrep tests repeat the slow path and fail. Give those tests a 120s timeout so the one-time download completes; later tests find the cached binary and stay fast.
2 tasks
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request increases the test timeout to 120 seconds for Ripgrep-related tests in both search.test.ts and ripgrep.test.ts. This adjustment prevents test failures on Windows CI runners where downloading and extracting the rg binary can exceed the default 5-second timeout. No review comments were provided, so there is no additional feedback to address.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the last 4
unit (windows)failures (+2 suite errors) blocking #28's runner switch. Re-opened from #34, which was auto-closed when its stacked base (#33's branch) merged and was deleted.Paperclip issue: LAC-2693
Problem
Of the 112 windows failures in the original report, 108 were already fixed by #33's LAC-2386 fixture/InstanceRef fixes. The remaining 4 failures + 2 errors are all in the Ripgrep test suites: the first
Ripgrep.Serviceuse on Windows downloads the rg zip and extracts it via PowerShellExpand-Archive, which blows bun's 5s default test timeout. The SIGTERM'd extraction never populates the cache, so every Ripgrep test repeats the slow path and fails the same way.Fix
Give the Ripgrep-dependent tests a 120s timeout: the first test pays the one-time download/extract cost and caches
rg.exe; subsequent tests short-circuit on the cache and run in milliseconds.Testing
unit (windows)on this branch's previous run (pre-rebase, same diff): watching CI on this PR for the definitive green.Acceptance criteria (LAC-2693)
unit (windows)job reachessuccess✅ (pending this PR's CI)