fix(test): extend timeout for ripgrep tests that download the rg binary (LAC-2693)#34
Closed
lacymorrow wants to merge 1 commit into
Closed
Conversation
…ry (LAC-2693) On Windows CI runners the first Ripgrep.Service use downloads the rg release zip and extracts it via PowerShell Expand-Archive, which exceeds bun's default 5s per-test timeout. The test SIGTERMs the extraction mid-flight, nothing is cached, and all four ripgrep tests repeat the slow path and fail. Give those tests a 120s timeout so the one-time download completes; later tests find the cached binary and stay fast.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request increases the test timeout to 120 seconds for Ripgrep-related tests in search.test.ts and ripgrep.test.ts. This prevents test failures on Windows CI runners where downloading and extracting the rg binary during the first run can exceed the default 5-second timeout. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the last remaining
unit (windows)failures for LAC-2693 (sibling of LAC-2386/linux).Stacked on #33 (which is stacked on #28). The LAC-2386 fixture/InstanceRef fixes already cleared 108 of the original 112 windows failures — the latest
unit (windows)run on #33 (job 86154739532) shows only 4 failures + 2 errors remaining, all in the Ripgrep suites.Root cause
On Windows, the first
Ripgrep.Serviceuse downloads the rg release zip and extracts it via PowerShellExpand-Archive(packages/core/src/ripgrep/binary.ts). That takes longer than bun's default 5s per-test timeout, so the test SIGTERMs the extraction mid-flight (error: Unknown: ChildProcess.exitCode (...powershell.exe ... Expand-Archive ...)), nothing gets cached, and every ripgrep test repeats the slow path:packages/core/test/ripgrep.test.ts— 2 testspackages/core/test/filesystem/search.test.ts— 2 testsFix
Give those 4 tests an explicit 120s timeout. Only the first one pays the download cost; it caches
rg.exeinGlobal.Path.bin, so subsequent tests short-circuit and stay fast. No behavior change on machines with rg on PATH (macOS/Linux dev machines: all 4 tests ran in 481ms locally).Acceptance criteria (LAC-2693)
unit (windows)job reachessuccess— verify on this PR's CI runTesting
bun test test/ripgrep.test.ts test/filesystem/search.test.tsinpackages/core: 4 pass, 0 fail (macOS)unit (windows)job