Revert "rewrite web2parser to DAHRManager" - #65
Merged
Conversation
tcsenpai
added a commit
that referenced
this pull request
May 6, 2026
…Int / computeSnapshotWeight kernel PR #778 review: - G-5: exact-equality `tallyBlock: currentBlock` lookup would leave a proposal stuck in "pending" forever if its tally block was ever skipped (devnet reset, reorg). Switch to `LessThanOrEqual` so overdue proposals are tallied on the next post-block pass. `applyNetworkUpgrade.ts` already uses a JS-side `<=` filter and is unaffected. - G-2: `safeBigInt` was duplicated identically in tallyUpgradeVotes and governanceHandlers; `computeSnapshotWeight` was duplicated with deliberately divergent error policies. Extract to `src/features/networkUpgrade/governanceWeight.ts` — shared `safeBigInt` and a re-throwing `computeSnapshotWeight` kernel that each caller wraps with its own policy (tally returns 0n on lookup failure for determinism; RPC handler surfaces the error). Mycelium tasks #63 and #65.
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #64