Repository navigation
Conversation
The app-server transport awaits an unbounded Deferred per request, so a wedged Codex app server parked the feedback/upload request forever. The upload carries the session logs and the client spins with no way to report the outcome. Extracted uploadCodexFeedback and bounded the wait at 60s, mapping the timeout to a CodexAppServerRequestError tagged method=feedback/upload, operation=receive-response. Same seam as turn/start (#4), which only covered turn/start and turn/interrupt. Evidence: new TestClock regression test in CodexSessionRuntime.test.ts - a never-resolving transport plus TestClock.adjust(61 seconds) fails on base (fiber still parked) and passes with the fix (fails with the request error). 50/50 tests green in the file; CodexAdapter suite 54/54 green. authored with AI assistance (Muse, Meta's Muse Spark) under the contributor's direction; reviewed and verified by the contributor before submission.
github-actions
Bot
added
vouch:trusted
This was referenced Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Bounds the Codex app-server
feedback/uploadrequest with a 60s timeout. The transport awaits an unbounded Deferred per request, so a wedged app server parked the feedback upload forever - the upload carries the session logs and the client spins with no way to report the outcome. The call was extracted intouploadCodexFeedback(next toreadCodexThread/rollbackCodexThread) and the timeout maps to aCodexAppServerRequestErrortaggedmethod=feedback/upload, operation=receive-response. Same seam as #4, which only coveredturn/startandturn/interrupt.Why
Submitting bug feedback is exactly the flow a user reaches for when something is already broken; if the app server is wedged at that moment, the feedback RPC hangs the handler fiber indefinitely instead of failing with a clear error. 60s (vs 30s for turn/start) because the upload ships the session log bundle.
UI Changes
None (backend-only). On timeout the client now receives a typed request error instead of an endless spinner.
Checklist
Evidence
CodexSessionRuntime.test.ts: a never-resolving transport +TestClock.adjust("61 seconds"), with a Deferred spawn gate so the bound cannot trip vacuously. Red on base:AssertionError: a wedged app server must not park the feedback upload forever(fiber still parked after 61 virtual seconds). Green with fix: fails with the taggedCodexAppServerRequestError.CodexAdapter.test.ts: 54/54 green.vp fmt --checkclean on both touched files.Effect.timeout+catchTag("TimeoutError")combinator chain: error channel collapses back toCodexAppServerError(full repo tsc aborts in this sandbox, documented env issue).authored with AI assistance (Muse, Meta's Muse Spark) under the contributor's direction; reviewed and verified by the contributor before submission.