Repository navigation
Conversation
This was referenced Oct 19, 2026
kvnloo
added a commit
that referenced
this pull request
Oct 19, 2026
Preserve the hidden-question habit composer guard, and incorporate #58's opt-in, imported-row-safe, rollover-safe native Journal correction and tests. Fork-only review integration.
This was referenced Oct 19, 2026
kvnloo
changed the base branch from
sync/origin-20261018-8e4b0c1
to
qa/noop-pinned-origin-20261019
October 19, 2026 21:43
This was referenced Oct 19, 2026
kvnloo
added a commit
that referenced
this pull request
Oct 19, 2026
This was referenced Oct 20, 2026
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-facing correctness issue
NOOP currently auto-writes yesterday's native Journal answers as today's real Yes/No rows when Insights opens on a blank day. Those fabricated observations can enter correlations and Personal Experiment adherence/effect views without the user observing or confirming anything.
Change (fork-only)
Source:
ryanbr/noop@8e4b0c1; fork commitf021af9. Changes are intentionally separate from fork #49 (explicit-No baseline selection); together they prevent two distinct kinds of false controls.Verification: Not yet run; fork CI pending. No device/clinical evidence. Intended review path: after CI is scheduled, retarget from fork main to exact pinned
sync/origin-20261018-8e4b0c1to remove unrelated upstream-sync changes. Do not submit upstream without authorization and independent review.Credit: Preserves NOOP authorship, data ownership, and PolyForm Noncommercial license.
2026-10-19 review hardening
Exact head
72b15a8aef6f65cd6086c5bbfbd9312609322bfdalso protects existing imported WHOOP answers for today (not just native rows), and invalidates stale suggestions at midnight before any copy. Seven JVM tests now cover imported/current-day collisions. Fresh Android CI and i18n CI were queued, not passed when recorded. The draft was returned to pinned-sync base to keep its accurate 9-file diff.Additional local verification (October 19): Exact helper Git blob
81ccab082a9ef33d1ba1f1f30d822688f9b32077materialized with byte-for-bytegit hash-objectmatch, compiled using localkotlinc, and passed 5 pure copy/gating tests (9 total shared Kotlin smoke checks alongside #54). Not Android app/Gradle CI, lifecycle/race integration, or device validation.