Repository navigation
Conversation
2 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (reference)
Fork-only successor to kvnloo/noop#51, an Android ephemeral contextual Today experiment. This is not a fix for an upstream issue or a proposal to
ryanbr/noop.Root cause (current-main source)
At
kvnloo/noop@2a1de7609843b095505274ad6fc811757210be80,android/app/src/main/java/com/noop/ui/AppRoot.kt:582-590displays the fullGlassBottomBarand:627-672displays the existingTodayScreen;android/app/src/main/java/com/noop/ui/BreatheScreen.kt:218has no optional post-session Journal action. The original fork experiment was on older base3a0b74b2da11617cc4d3ce6452c8c5b990a7798f.Change
1156204e460dc2cf3d4895d4b900c1a97ddd4792). Its first commit directly follows that old base: no stacked parent fork PR or inherited changes.2a1de760; replace contextual-screen typography/spacing with currentNoopType/Metricstokens (with existingPalettecolors); addvalues-it,values-pl,values-ru,values-zhto match the four additional shipped Android locale directories on current main. All 9 locales have the same 25 contextual string keys. Update experiment documentation to thisfork/branch.Tests
UNRUN. GitHub Actions is disabled on
kvnloo/noop; no workflow has been dispatched and no passing checks are claimed. The commit re-reads atf68cd7c3892ff4f179435f9d0bf5190993751bc1matched all 15 files, and the base-to-head comparison is exactly 1 commit, 15 paths, 0 behind.ContextualTodayScreenTestadds 7 cases for active-session precedence, stale-scanning/connected precedence, offline/waiting/review decisions and invalid Charge suppression;BreatheOutcomeTestadds 2 for fresh/non-abandoned check-in and next wake-day rollover.visibleChargePercent(61.6) = 62(nearest integer);null,NaN,+∞,-1and101stay unavailable. Connected=true + scanning=true + hasCharge=true selectsREVIEW_DAY, notSCANNING; activeWorkout=true wins even while disconnected. A session shorter than 120 seconds has no completed outcome; a fresh "—" outcome permits manual check-in but asserts no HRV estimate.journalDayKey(-1, 2026-12-31) = 2027-01-01, andjournalDayKey(-1, 2028-02-28) = 2028-02-29.Hardware needed
No new BLE command, pairing state machine or firmware action. Real Android phone + WHOOP strap required to validate connect/scanning/reconnect prompt transitions, active-workout handoff, accessibility/TalkBack, large fonts, light/dark themes and device navigation. No strap or device test performed here.
Upstream readiness
FORK-ONLY; not upstream-ready and not a merge candidate.
fork/feature under RFC-0, for opt-in channel composition. In particular, original #51 says longitudinal Breathe → Journal pilots need either #53 or #58 for explicit answer semantics; they are pilot-safety dependencies, not ancestry or code prerequisites. Do not claim pilot efficacy or merge both without review. Exact-head external runner + physical UX checks remain open.Do not merge; source for channels/nightly.
Implemented by ChatGPT (mobile app, GitHub connector) for Kevin's NOOP factory.