PR just to show the difference, not for merging - #8
Conversation
…eters] This has the effect of making the car veer less towards a disappearing lane line because it assumes that the lane width is less. It may also improve curb performance. Copied from rdm128
There was a problem hiding this comment.
Thanks! I'll pull in the Atlas fingerprint and tuning values as-is.
For turn signals, that's been on my todo list, but I'd like to do it a little differently. Ideally I'd like to see it with, or next to, the CS.steer_override check so we get smooth ramp-down of applied torque. If you want to turn the steer_override (and new turn signal) torque divisor(s) into named constants like STEER_MAX that would be fine, or I wouldn't necessarily object to clipping to zero for turn signals.
Also, for proper working with comfort blinkers (one touch gets ~6 seconds of blinking for a lane change) we would need to implement it with a minimum disable timer on leading edge of the signal going high.
|
Will integrate some of these changes later, in spirit, but both the Comma and VW codebases have been refactored significantly since this PR. |
3d90c78 Fix wrong event enum f4c92cf add none/invalid usb power mode 12bc189 Add fields and states required for robust Volkswagen safety compliance (#8) 16b5850 let's spell wolkswagen 6243622 Safety cereal (#9) 5cf3c2c change order of UsbPowerMode to preserve panda lib behavior 18a2917 usbPowerMode is more useful to log and it comes from panda 1526784 add ldw to visual hud alerts (#5) 24f6fa7 merge commaai/msgq#3 after fixing conflicts 4d5862c added event about internet connection ca070f9 Added usbPowerOn to health e2eaa76 add HW type for UNO e528a20 Read RPM from fan connected to Panda 8472175 Added invalidGiraffeToyota event 71be970 placeholders for mazda, nissan and vw safety models git-subtree-dir: cereal git-subtree-split: 3d90c78
3d90c78 Fix wrong event enum f4c92cf add none/invalid usb power mode 12bc189 Add fields and states required for robust Volkswagen safety compliance (#8) 16b5850 let's spell wolkswagen 6243622 Safety cereal (#9) 5cf3c2c change order of UsbPowerMode to preserve panda lib behavior 18a2917 usbPowerMode is more useful to log and it comes from panda 1526784 add ldw to visual hud alerts (#5) 24f6fa7 merge commaai/msgq#3 after fixing conflicts 4d5862c added event about internet connection ca070f9 Added usbPowerOn to health e2eaa76 add HW type for UNO e528a20 Read RPM from fan connected to Panda 8472175 Added invalidGiraffeToyota event 71be970 placeholders for mazda, nissan and vw safety models git-subtree-dir: cereal git-subtree-split: 3d90c78
2 participants
@jyoung8607 Just for showing the changes to values.py and interface.py for Atlas.
Don't merge this PR in as it contains some other small mods I made (eg. I prefer having OP disabled while blinkers are on and the ability to enable it at the red light).