Bring current with upstream OP 0.6.1 - #15
Merged
Merged
Conversation
* tabs to spaces python 2 to 3: https://portingguide.readthedocs.io/en/latest/syntax.html#tabs-and-spaces * use the new except syntax python 2 to 3: https://portingguide.readthedocs.io/en/latest/exceptions.html#the-new-except-syntax * make relative imports absolute python 2 to 3: https://portingguide.readthedocs.io/en/latest/imports.html#absolute-imports * Queue renamed to queue in python 3 Use the six compatibility library to support both python 2 and 3: https://portingguide.readthedocs.io/en/latest/stdlib-reorg.html#renamed-modules * replace dict.has_key() with in python 2 to 3: https://portingguide.readthedocs.io/en/latest/dicts.html#removed-dict-has-key * make dict views compatible with python 3 python 2 to 3: https://portingguide.readthedocs.io/en/latest/dicts.html#dict-views-and-iterators Where needed, wrapping things that will be a view in python 3 with a list(). For example, if it's accessed with [] Python 3 has no iter*() methods, so just using the values() instead of itervalues() as long as it's not too performance intensive. Note that any minor performance hit of using a list instead of a view will go away when switching to python 3. If it is intensive, we could use the six version. * Explicitly use truncating division python 2 to 3: https://portingguide.readthedocs.io/en/latest/numbers.html#division python 3 treats / as float division. When we want the result to be an integer, use // * replace map() with list comprehension where a list result is needed. In python 3, map() returns an iterator. python 2 to 3: https://portingguide.readthedocs.io/en/latest/iterators.html#new-behavior-of-map-and-filter * replace filter() with list comprehension In python 3, filter() returns an interatoooooooooooor. python 2 to 3: https://portingguide.readthedocs.io/en/latest/iterators.html#new-behavior-of-map-and-filter * wrap zip() in list() where we need the result to be a list python 2 to 3: https://portingguide.readthedocs.io/en/latest/iterators.html#new-behavior-of-zip * clean out some lint Removes these pylint warnings: ************* Module selfdrive.car.chrysler.chryslercan W: 15, 0: Unnecessary semicolon (unnecessary-semicolon) W: 16, 0: Unnecessary semicolon (unnecessary-semicolon) W: 25, 0: Unnecessary semicolon (unnecessary-semicolon) ************* Module common.dbc W:101, 0: Anomalous backslash in string: '\?'. String constant might be missing an r prefix. (anomalous-backslash-in-string) ************* Module selfdrive.car.gm.interface R:102, 6: Redefinition of ret.minEnableSpeed type from float to int (redefined-variable-type) R:103, 6: Redefinition of ret.mass type from int to float (redefined-variable-type) ************* Module selfdrive.updated R: 20, 6: Redefinition of r type from int to str (redefined-variable-type)
* Add lane departure alert in controlsd * Need init values for LDA * Add lane departure in interface.py * Include LDA in CarControler * Add logic for LDA in toyotacan * Add speed condition and comments for LDA * Correct right CS.vEgo * Correct rPoly spelling * Add left and rightLaneDepart to HUDControl in car.capnp * Add left and rightLane_Depart in UI function * set controlsd priority * revert * There must be a line to depart from * Include changes from @pd0wm * Remove redundant False allocation leftLaneDepart and rightLaneDepart as False by default according to @pd0wm * Modify variable names right_lane_depart and left_lane_depart to conform with python naming convention * Modify variable names right_lane_depart and left_lane_depart to conform with python naming convention * Wrap lane departure warning in one bool
* Update pip in CI * Longer timeout for docker build * Increase travis timeout * revert changes to travis file
3e199cb Subaru safety: ES_LKAS message should not be forwarded 252dec2 Change docker tags in jenkins to use git commit instead of build_id 4a3b587 generate dependencies and clean (#184) 005e131 Toyota Safety: cleaned up logic for TSSP2.0 cars b53fb27 add ACCEL_CMD to filtering for TSSP2.0 cars (#185) 18c2e69 Fix query_vin_and_status.py require python 3.7 3b351b7 Minor fix to current type git-subtree-dir: panda git-subtree-split: 3e199cb
4fc6f63 Update metric value for Dash_Units (#164) 340ca18 Subaru: added lane line visibility to ES_LKAS message 6b1246d Subaru: added hud unit selection 829ca5e Update subaru_outback_2015_eyesight.dbc (#163) 5d884df add Chrysler ACC resume button (#161) ba2a69b DBC for the Bosch Radar for Tesla (#158) 7aacee1 Lexus GS300h 2017 DBC (#159) d6eb4ae Rav4 2019 ADAS (#160) git-subtree-dir: opendbc git-subtree-split: 4fc6f63
Add lane lines visible indicators to Subaru dash display
Fix registration's params get_git_remote()
* Add 2019 RAV4 XLE fingerprints
“thansk” to “thanks”
Added fingerprint for 2019 Highlander XLE
7f8babb Much more thorough limit safety tests on Honda, also switching long_controls_allowed 71099ef AddedToyota safety test around long_controls_allowed logic and fixed a bug 07fd31e added long_controls_allowed tests in GM 6ce580a added function to get/set long_controls_allowed a2f93d4 update VERSION 380b7c7 Long allowed (#202) 09714e3 Toyota gas cancellation (#200) 436b203 Honda safety: fixed bug and properly abstracted gas_interceptor_detected variable 220cc8f Honda safety: this concludes the proper re-naming a00a50c Honda safety: better naming 95b0109 Toyota: fixed regression safety tests 192fd05 Toyota safety: fixed rounding logic 0c5b220 Merge pull request #194 from commaai/refactor b35f6ff legacy build is no longer supported a06af9f always LIVE on EON dc5979f LIVE on EON 0b26645 no EON by default 1906a4b panda now draws below 100mw in power save mode e70b44a move that to main.c dfce5f6 minor fixes, and no more autobaud 7f303e8 bump version to 1.3.0 96a7e31 a soothing blue in power save mode a74f001 refactor power savings to depend on car started bit 386d5df can wake from sleep is removed, didn't work in the first place 881b1f4 not on pedal chip 0a9f8eb remove many ifdef PANDA 5069005 remove nested includes and include guards 3810452 WTF WHY WAS THIS SHIT PUT EVERYWHERE 3cf8db9 can.h always has CAN3 1f97c21 refactor pedal bootstub to use llcan 58ec63b oops, backward 6255097 new style power savings 6b282f1 tesla doesn't need a special LIN hook 1d24677 refactor #ifdef EON d9306c5 NEO are no longer supported 4af036e fixup puts 2c1e5f6 the refactor continues 7517f2c remove ifdef PANDA from main aec40ae remove fan, as it was only for NEO board 605bb27 fix bootstub build c0f1f6e move things around for simplicity f32f039 factor out clear_send 8221927 this is probably broken. refactor out llcan and clock 1114cb1 ELM327 safety mode: re use existing functions cd104e2 Vin query msg is 0x7df 223323a Examples: fixed import bug 533d239 update price 4396fb9 Update jenkinsfile (#193) 1aa00c9 Misra c2012 (#192) 047bd72 fix tests and remove rev b support git-subtree-dir: panda git-subtree-split: 7f8babb
38650f8 Toyota: STEERING_LTA actually has an angle interface a0394d4 Toyota LTA: back to unit factor 0a03d08 Honda: fix China model. Toyota: add STEERING_LTA message for nodsu cars f1c17ae Toyota dsu-less: more precise steering angle conversion 0e94a29 Toyota: better pt dbc file naming for all dsuless cars 9199a55 Toyota: better name for adas bdc files f5ddc1c Toyota DSU-less: added better measurement of steer angle c60b91f Toyota Camry: using the same conversion factor for STEER_TORQUE_EPS as in the CHR git-subtree-dir: opendbc git-subtree-split: 38650f8
d54ef825d Merge pull request #1 from commaai/new-usr e3e0520e4 put back logentries and overpy c3ad0b3dd remove everything git-subtree-dir: pyextra git-subtree-split: d54ef825db8d96de8c960ac57a33ac11fa7728bf
* exclude tools from linter * Exclude tools from pylint too
Update README
* sort dbc files to make linking deterministic * touch all files on release2 checkout to prevent rebuild
* move civic params out * fix variable name * simplify ford scaling * cleanup * remove import dependency * requested changes * keep hyundai
* Fingerprint * Merge Limited and XLE fingerprint because they're the same
Tested latest commit on ICE version, and it worked flawlessly out of box. Fantastic experience.
4ea03ba add speed 2198ad2 add alert for invalid posenet 9c18b3b rename to posenetValid 42669a8 add posenet debug fields to LiveParameters 852846f add whether point is detected by radar 1684698 add model prob fb87dba added HW type to support various panda versions 820bf7b added tooDistracted event 1105dc1 different name 45c4249 add second model lead f8c557f Log can errors from panda 04f105a back ff93320 add lead stuff git-subtree-dir: cereal git-subtree-split: 4ea03ba
45d0d28 remove whitespace (#255) e49d0db Pedal: use avg between tracks (#253) c597dcc VERSION update after health packet changes and minor misra test change 01072be Misra 11.x: pointer usage. (#250) fd68c26 Propagate can_push errors (#249) ce1daf2 Misra check only done for EON config 70d4fd7 cleanup docker container on failure 04756a0 Turning back Misra check: unvoluntarily change fcb1208 fix weird code in USB_ReadPacket b983cc8 Re-wrote test_misra.sh 0b19206 Misra 17.7: The value returned by a function having non-void return type shall be used. We should hang on initial failed safety_set_mode 06ee8bd Ignore Misra 5.4 until cppcheck bug (?) is fixed 4be8582 Update cppcheck commit and pass predefined params to avoid impossible combinations of configs f45dd04 cppcheck: ignore redundantAssignment and selfAssignment for registers in llcan.h 9ce6311 Misra 12.1 (operator order) and 10.4 (incompatible essential types) fixes, arised after properly checking UID_BASE config 1cd34e5 Explicitly set the define and undefine for unknown configs in misra checks 5a02499 remove esp flash from run_automated_tests.sh 23e3684 Cppcheck unused functions (#247) c97d60b Removed bad language b031480 Missed adding Dockerfile 91ff6bb Run language checker in CI 205ec34 Improved language checker f7bbab0 Language checker test d9d0a62 Misra 5.5: missed this change from previous PR 85fa3c0 Misra 5.5: Identifiers shall be distinct from macro names (#246) 190d604 Pedal: 2 minor fixes to Misra 15.7 (else needed) and 17.7 (non-void output must be used) 8ea01ff Pedal: no built-in functions to avoid puts and putc re-definitions 1f40d1e Misra pedal (#245) a4554e3 Ignore advisory Misra 19.2: the union keyword should not be used e6dc417 Minor indent error 247e128 Fix strict compiler on bootstub build ba68569 Removed build strict test and enabled -Werror flag da11f0f safety replay: update openpilot-tools after logreader fix fc8b9e4 Cppcheck: also check pedal f7bd2c2 Misra 10.4: fix last 2 violations (#242) 9be5fde finished misra 17.8 (#241) 3c3aba3 Misra 10.4: Both operands of an operator in which the usual arithmetic conversions are performed shall have the same essential type category (#240) f2a3a17 Misra 15_7: fix what seems to be a false positive of cppcheck 812ace5 Misra 15_7: if … else if constructs should be terminated with an else clause (#230) 79e9735 rename 5_wifi_udp.py 3c3ff0c Update Jenkinsfile (#239) 1bd9284 Misra 17.7: the value returned by a function having non-void return shall be used (#237) 18c9e88 Merge pull request #238 from commaai/misra_17_8 7ac321d Merge pull request #235 from commaai/memxxx 004e543 Jenkins: run EON test first 4bff286 Merge branch 'memxxx' of github.com:commaai/panda into memxxx 7cd80de typo 385e33b 12.1 regression 955842b WIP ea908cb 10_1 violations: Operands shall not be of an inappropriate essential type (#233) fa33038 Fix Misra 5.3: An identifier declared in an inner scope shall not hide an identifier declared in an outer scope (#236) ebfe1c5 Merge branch 'master' of github.com:commaai/panda into memxxx 8c11470 Fix EON test case 64e18e8 fix inverted logic to differentiate between dev and EON panda builds 36755a0 Merge branch 'master' of github.com:commaai/panda into memxxx e2981d6 skip wifi tests for EON panda build db2eec9 Merge branch 'master' of github.com:commaai/panda into memxxx 11257e7 Ignore test 5_wifi_udp.py_ignore: too unreliable for now 6973c2a fix wifi tests cf6985a memxxx function changes to be Misra compliant 3a6cd29 wifi threshold perc back to 20%. Problem wasn't this. d92a035 faster docker build for safety replay 3e9469b Fixing tests after min->MIN change ecb9b6c Revert "Misra 10 1: Operands shall not be of an inappropriate essential type (#232)" 8732e4f Misra 10 1: Operands shall not be of an inappropriate essential type (#232) git-subtree-dir: panda git-subtree-split: 45d0d28
Dennis-NL
pushed a commit
to Dennis-NL/openpilot
that referenced
this pull request
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.