Repository navigation
Assert unreachable paths instead of returning errors - #324
Merged
Merged
Conversation
Fuzzing and AI static analysis found these wholly unreachable, so they are converted to asserts. 32-bit builds keep explicit overflow checks.
Merging this PR will not alter performance1 warning
Comparing |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #324 +/- ##
==========================================
+ Coverage 88.74% 90.28% +1.53%
==========================================
Files 41 41
Lines 5677 5597 -80
Branches 1526 1513 -13
==========================================
+ Hits 5038 5053 +15
+ Misses 254 165 -89
+ Partials 385 379 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owner
Author
|
coverage will be provided in a dedicated PR, branch |
jquast
added a commit
that referenced
this pull request
Nov 13, 2026
Raise libwcwidth line coverage to 100%, branch coverage varies by compiler, CI reports almost 96, but the limit is set to 89. By testing reachable paths, enabling assertions with #324, Careful fuzzing, tests, and consideration is given to try to discover wither code is truly unreachable, and input-size-dependent overflow checks are given for 32-bit builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fuzzing and AI static analysis found these wholly unreachable, so they
are converted to asserts. 32-bit builds keep explicit overflow checks.