Repository navigation
Full line coverage of libwcwidth, ~96% branch - #328
Merged
Merged
Conversation
By testing reachable paths, enabling assertions, and most importantly: deleting unreachable code. Careful fuzzing, tests, and consideration is given to try to discover wither code is truly unreachable, and input-size-dependent overflow checks are given for 32-bit builds.
The phrasing cleanups now live on docs/comment-phrasing, leaving this branch with the 100% libwcwidth coverage work alone.
# Conflicts: # libwcwidth/CMakeLists.txt # libwcwidth/src/sgr.c # libwcwidth/src/textwrap.c # libwcwidth/src/width.c # libwcwidth/tests/test_oom.c # libwcwidth/tests/test_sgr.c # libwcwidth/tests/test_textwrap.c # setup.py # tests/test_core.py # tox.ini
jquast
marked this pull request as ready for review
November 13, 2026 17:24
Merging this PR will not alter performance1 warning
Comparing 
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #328 +/- ##
==========================================
+ Coverage 91.46% 95.91% +4.44%
==========================================
Files 44 44
Lines 6388 6384 -4
Branches 1806 1773 -33
==========================================
+ Hits 5843 6123 +280
+ Misses 164 0 -164
+ Partials 381 261 -120 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jquast
changed the title
jquast
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings C11 libwcwidth coverage to 100% line coverage and ~96% branch coverage.