Skip to content

chore(ci): replace actionlint with zizmor #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 2 commits into from
Sep 11, 2026
Merged

chore(ci): replace actionlint with zizmor #1409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8929cb
chore(ci): use self-repository workflow references
jdx Sep 10, 2026
b7a575b
chore(ci): replace actionlint with zizmor
jdx Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .cursor/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ set -euo pipefail
export PATH="$HOME/.local/bin:$HOME/.cargo/bin:$PATH"

# Trust the repo's mise config and install every pinned tool from mise.toml
# (go, node, python, prettier, actionlint, insta, shellcheck, ...). Idempotent:
# (go, node, python, prettier, insta, shellcheck, ...). Idempotent:
# already-present tools are a fast no-op.
mise trust --yes
mise install
Expand Down
22 changes: 0 additions & 22 deletions .github/actionlint.yaml
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@ jobs:
if: ${{ github.actor == 'jdx' && (github.event_name != 'pull_request' || (github.event.pull_request.head.repo.full_name == github.repository && github.event.pull_request.user.login == 'jdx')) }}
permissions:
contents: read
uses: ./.github/workflows/test-impl.yml
uses: $/.github/workflows/test-impl.yml

@greptile-apps greptile-apps Bot Sep 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Invalid workflow reference

GitHub Actions accepts same-repository reusable workflows through the ./.github/workflows/<workflow> form, not $/.github/workflows/test-impl.yml. Both this job and the untrusted job on line 23 use the unsupported form, so pull requests and pushes to main fail workflow validation instead of running the test workflow. The reported zizmor audit does not validate that GitHub can resolve this reference.

Fix in Claude Code

with:
trusted: true

untrusted:
if: ${{ github.actor != 'jdx' || (github.event_name == 'pull_request' && (github.event.pull_request.head.repo.full_name != github.repository || github.event.pull_request.user.login != 'jdx')) }}
permissions:
contents: read
uses: ./.github/workflows/test-impl.yml
uses: $/.github/workflows/test-impl.yml
with:
trusted: false

Expand Down
46 changes: 0 additions & 46 deletions mise.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ mr-boxington = "1.8.3"
# upgrade that changes how it samples would land in the series as a step change
# in usage's numbers, indistinguishable from a real regression. Bump deliberately.
"github:jdx/tak" = "v0.0.9"
actionlint = "latest"
aube = "latest"
communique = "latest"
cargo-binstall = "1.22.0"
Expand Down Expand Up @@ -88,8 +87,6 @@ run = [

[tasks.lint]
depends = ['lint:*']

@greptile-apps greptile-apps Bot Sep 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Workflow validation removed

Removing lint:actionlint eliminates general GitHub Actions validation from both the CI lint job and the pre-commit lint hook. Zizmor performs security auditing rather than equivalent workflow syntax, expression, structure, and runner-label validation. Future workflow mistakes can therefore merge without being caught by the repository's lint suite; retain actionlint or add an equivalent validator.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code

[tasks."lint:actionlint"]
run = 'actionlint'
[tasks."lint:prettier"]
run = "prettier -c ."
[tasks."lint:clippy"]
Expand Down