chore(ci): replace actionlint with zizmor - #1409
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe test workflow updates reusable workflow references for the ChangesTest workflow and lint configuration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to The workflow reference updates and actionlint cleanup are ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes. Shadow comparisonParsing
|
cc3b0a4 to
b7a575b
Compare
|
| permissions: | ||
| contents: read | ||
| uses: ./.github/workflows/test-impl.yml | ||
| uses: $/.github/workflows/test-impl.yml |
There was a problem hiding this comment.
GitHub Actions accepts same-repository reusable workflows through the ./.github/workflows/<workflow> form, not $/.github/workflows/test-impl.yml. Both this job and the untrusted job on line 23 use the unsupported form, so pull requests and pushes to main fail workflow validation instead of running the test workflow. The reported zizmor audit does not validate that GitHub can resolve this reference.
| @@ -88,8 +87,6 @@ run = [ | |||
|
|
|||
| [tasks.lint] | |||
| depends = ['lint:*'] | |||
There was a problem hiding this comment.
Removing lint:actionlint eliminates general GitHub Actions validation from both the CI lint job and the pre-commit lint hook. Zizmor performs security auditing rather than equivalent workflow syntax, expression, structure, and runner-label validation. Future workflow mistakes can therefore merge without being caught by the repository's lint suite; retain actionlint or add an equivalent validator.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
### 🚀 Features - **(help)** allow remapping semantic colours on Style by [@lu-zero](https://github.com/lu-zero) in [#1414](#1414) - **(parse)** add opt-in default-subcommand flag routing by [@jdx](https://github.com/jdx) in [#1413](#1413) - **(parse)** parse Args without an enclosing CLI by [@jdx](https://github.com/jdx) in [#1419](#1419) ### 🐛 Bug Fixes - **(bash)** preserve colon-prefixed completion words by [@jdx](https://github.com/jdx) in [#1405](#1405) ### 📚 Documentation - write PR titles and descriptions for release notes by [@jdx](https://github.com/jdx) in [#1415](#1415) ### ⚡ Performance - **(cli)** shrink help sorting without allocating cached keys by [@jdx](https://github.com/jdx) in [#1396](#1396) - **(cli)** make advanced help and runtime spec serialization optional by [@jdx](https://github.com/jdx) in [#1399](#1399) - **(cli)** share help sorting and skip unused rendering work by [@jdx](https://github.com/jdx) in [#1400](#1400) - **(cli)** avoid color analysis for plain help by [@jdx](https://github.com/jdx) in [#1401](#1401) ### 🔍 Other Changes - **(ci)** use self-repository workflow references by [@jdx](https://github.com/jdx) in [#1409](#1409) ### 📦️ Dependency Updates - lock file maintenance by [@renovate[bot]](https://github.com/renovate[bot]) in [#1398](#1398) - update jdx/renovate-config digest to 8cabc2e by [@renovate[bot]](https://github.com/renovate[bot]) in [#1406](#1406) - update zizmorcore/zizmor-action action to v0.6.3 by [@renovate[bot]](https://github.com/renovate[bot]) in [#1403](#1403) - update dependency go to v1.27.1 by [@renovate[bot]](https://github.com/renovate[bot]) in [#1407](#1407) - update actions/deploy-pages action to v5 by [@renovate[bot]](https://github.com/renovate[bot]) in [#1404](#1404) - update communique to v1.4.0 by [@jdx](https://github.com/jdx) in [#1416](#1416) ### New Contributors - @lu-zero made their first contribution in [#1414](#1414)
GitHub now recommends the
$/self-repository syntax, and zizmor 1.30.0 audits the older./form. actionlint 1.7.12 does not recognize$/, which made the earlier version of this PR fail its own lint job.Remove actionlint from usage's toolchain, lint tasks, lockfile, and repository-specific configuration. Keep the trusted and untrusted test workflow calls on
$/; the existing zizmor workflow now provides the maintained GitHub Actions audit.Validation:
mise lock --dry-run --jsonreturned[]mise tasksloaded the updated task configurationgit diff --check origin/main...HEADpassedAI-assisted — Tool: Codex; model: OpenAI/GPT-5; version: unavailable.