Skip to content

Isolate dependency installs from inherited Git repository state - #2506

Merged
j178 merged 6 commits into
j178:masterfrom
will-wright-eng:fix/scrub-git-repo-env-var
Aug 8, 2026
Merged

Isolate dependency installs from inherited Git repository state#2506
j178 merged 6 commits into
j178:masterfrom
will-wright-eng:fix/scrub-git-repo-env-var

Conversation

@will-wright-eng

@will-wright-eng will-wright-eng commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Hook dependency installers can invoke Git while GIT_DIR and GIT_INDEX_FILE still point at the user's repository. Nested clones can then inspect or rewrite the user's index.

Isolate npm, Bun, Dart pub, Cabal, Julia Pkg, Composer, and SwiftPM dependency commands from repository-local Git state.

Closes #2505

@will-wright-eng
will-wright-eng requested a review from j178 as a code owner August 7, 2026 21:43
@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.60%. Comparing base (f3115b3) to head (6fa029d).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2506      +/-   ##
==========================================
- Coverage   93.61%   93.60%   -0.01%     
==========================================
  Files         131      131              
  Lines       28416    28401      -15     
==========================================
- Hits        26602    26586      -16     
- Misses       1814     1815       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@prek-ci-bot

prek-ci-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

📦 Cargo Bloat Comparison

Binary size change: +0.68% (29.6 MiB → 29.8 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size             Crate Name
 1.1%   2.3% 332.0KiB        aws_lc_sys aws_lc_0_43_0_aes_gcm_encrypt_avx512
 1.1%   2.3% 332.0KiB        aws_lc_sys aws_lc_0_43_0_aes_gcm_decrypt_avx512
 0.2%   0.5%  71.9KiB              prek <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  58.0KiB              prek <<prek::config::Config as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.2%   0.3%  49.4KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.3%  48.1KiB              prek prek::run::{closure#0}
 0.1%   0.3%  38.5KiB              prek prek::cli::run::run::run::{closure#0}
 0.1%   0.2%  34.2KiB              prek <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  33.0KiB              prek <prek::languages::ruby::installer::RubyInstaller>::install::{closure#0}
 0.1%   0.2%  30.1KiB     granit_parser <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
 0.1%   0.2%  29.4KiB              prek <<prek::config::RemoteHook as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  28.6KiB    cargo_metadata <&mut serde_json::de::Deserializer<serde_json::read::StrRead> as serde_core::de::Deserializer>::deserialize_struct::<<cargo_metadata::Package as serde_core::de::Deserialize>::deserialize::__Visitor>
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_43_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_43_0_edwards25519_scalarmuldouble
 0.1%   0.2%  27.2KiB              prek <prek::languages::deno::installer::DenoInstaller>::download::{closure#0}
 0.1%   0.2%  25.8KiB              prek prek::cli::try_repo::try_repo::{closure#0}
 0.1%   0.2%  25.6KiB              prek <<prek::config::LocalHook as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  25.2KiB              prek <<prek::config::UpdateOptions as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  24.9KiB               xml <xml::reader::parser::PullParser>::dispatch_token
 0.1%   0.2%  24.1KiB              prek prek::cli::update::update::{closure#0}
42.5%  88.4%  12.7MiB                   And 26353 smaller methods. Use -n N to show more.
48.1% 100.0%  14.3MiB                   .text section size, the file size is 29.8MiB

Base Branch Results

 File  .text     Size             Crate Name
 1.1%   2.3% 332.0KiB        aws_lc_sys aws_lc_0_43_0_aes_gcm_encrypt_avx512
 1.1%   2.3% 332.0KiB        aws_lc_sys aws_lc_0_43_0_aes_gcm_decrypt_avx512
 0.3%   0.6%  86.7KiB              prek <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  58.3KiB              prek <<prek::config::Config as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.2%   0.3%  49.4KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.3%  47.9KiB              prek prek::run::{closure#0}
 0.1%   0.3%  38.7KiB              prek prek::cli::run::run::run::{closure#0}
 0.1%   0.2%  34.1KiB              prek <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  33.0KiB              prek <prek::languages::ruby::installer::RubyInstaller>::install::{closure#0}
 0.1%   0.2%  30.1KiB     granit_parser <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
 0.1%   0.2%  29.4KiB              prek <<prek::config::RemoteHook as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  28.6KiB    cargo_metadata <&mut serde_json::de::Deserializer<serde_json::read::StrRead> as serde_core::de::Deserializer>::deserialize_struct::<<cargo_metadata::Package as serde_core::de::Deserialize>::deserialize::__Visitor>
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_43_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_43_0_edwards25519_scalarmuldouble
 0.1%   0.2%  27.2KiB              prek <prek::languages::deno::installer::DenoInstaller>::download::{closure#0}
 0.1%   0.2%  25.8KiB              prek prek::cli::update::update::{closure#0}
 0.1%   0.2%  25.7KiB              prek prek::cli::try_repo::try_repo::{closure#0}
 0.1%   0.2%  25.3KiB              prek <<prek::config::LocalHook as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  25.2KiB              prek <<prek::config::UpdateOptions as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
 0.1%   0.2%  24.9KiB               xml <xml::reader::parser::PullParser>::dispatch_token
42.3%  88.1%  12.5MiB                   And 26240 smaller methods. Use -n N to show more.
48.0% 100.0%  14.2MiB                   .text section size, the file size is 29.6MiB

@prek-ci-bot

prek-ci-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

⚡️ Hyperfine Benchmarks

Summary: 0 regressions, 0 improvements above the 10% threshold.

Environment
  • OS: Linux 6.17.0-1020-azure
  • CPU: 4 cores
  • prek version: prek 0.4.12+25 (3230f6c 2026-08-08)
  • Rust version: rustc 1.97.1 (8bab26f4f 2026-07-14)
  • Hyperfine version: hyperfine 1.20.0
CLI Commands

Benchmarking basic commands in the main repo:

prek --version

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base --version 2.4 ± 0.1 2.2 2.7 1.05 ± 0.07
prek-head --version 2.3 ± 0.1 2.1 3.0 1.00

prek list

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base list 9.9 ± 0.4 9.5 12.6 1.03 ± 0.04
prek-head list 9.6 ± 0.2 9.3 10.4 1.00

prek validate-config .pre-commit-config.yaml

⏭️ Skipped: .pre-commit-config.yaml not found

prek sample-config

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base sample-config 2.7 ± 0.0 2.6 2.8 1.07 ± 0.03
prek-head sample-config 2.5 ± 0.1 2.4 2.7 1.00
Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

prek run --all-files (cold - no cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 40.9 ± 1.9 38.6 44.3 1.02 ± 0.05
prek-head run --all-files 40.2 ± 1.0 38.8 41.7 1.00

prek run --all-files (warm - with cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 40.5 ± 1.1 37.9 43.3 1.01 ± 0.04
prek-head run --all-files 40.1 ± 1.0 37.6 42.0 1.00
Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

prek run --all-files (full builtin hook suite)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 40.4 ± 1.0 38.6 43.4 1.01 ± 0.03
prek-head run --all-files 40.2 ± 1.0 38.0 42.4 1.00
Individual Hook Performance

Benchmarking each hook individually on the test repo:

prek run trailing-whitespace --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run trailing-whitespace --all-files 14.1 ± 0.3 13.2 14.8 1.04 ± 0.04
prek-head run trailing-whitespace --all-files 13.6 ± 0.3 13.0 14.2 1.00

prek run end-of-file-fixer --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run end-of-file-fixer --all-files 11.7 ± 0.4 11.0 12.7 1.00 ± 0.06
prek-head run end-of-file-fixer --all-files 11.7 ± 0.5 10.8 12.7 1.00

prek run check-json --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-json --all-files 8.4 ± 0.2 7.9 8.8 1.06 ± 0.05
prek-head run check-json --all-files 8.0 ± 0.3 7.5 8.6 1.00

prek run check-yaml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-yaml --all-files 8.1 ± 0.1 7.9 8.5 1.04 ± 0.03
prek-head run check-yaml --all-files 7.8 ± 0.1 7.5 8.2 1.00

prek run check-toml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-toml --all-files 8.2 ± 0.3 7.8 9.1 1.04 ± 0.06
prek-head run check-toml --all-files 7.9 ± 0.3 7.5 8.8 1.00

prek run check-xml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-xml --all-files 8.3 ± 0.5 7.6 9.3 1.06 ± 0.08
prek-head run check-xml --all-files 7.9 ± 0.3 7.4 9.0 1.00

prek run detect-private-key --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run detect-private-key --all-files 11.7 ± 0.6 10.7 13.4 1.02 ± 0.07
prek-head run detect-private-key --all-files 11.4 ± 0.5 10.6 12.6 1.00

prek run fix-byte-order-marker --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run fix-byte-order-marker --all-files 13.8 ± 0.8 12.6 15.3 1.02 ± 0.08
prek-head run fix-byte-order-marker --all-files 13.6 ± 0.7 12.3 15.6 1.00
Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

prek install-hooks (cold - no cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base install-hooks 4.9 ± 0.1 4.8 5.0 1.07 ± 0.02
prek-head install-hooks 4.6 ± 0.0 4.5 4.6 1.00

prek install-hooks (warm - with cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base install-hooks 5.0 ± 0.1 4.9 5.1 1.07 ± 0.02
prek-head install-hooks 4.6 ± 0.0 4.6 4.7 1.00
File Filtering/Scoping Performance

Testing different file selection modes:

prek run (staged files only)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run 25.2 ± 0.6 24.4 26.4 1.00
prek-head run 26.2 ± 2.8 24.4 34.1 1.04 ± 0.11

prek run --files '*.json' (specific file type)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --files '*.json' 5.8 ± 0.1 5.6 6.2 1.06 ± 0.06
prek-head run --files '*.json' 5.4 ± 0.3 5.2 6.2 1.00
Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

prek run --dry-run --all-files (measures init overhead)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --dry-run --all-files 8.0 ± 0.2 7.6 8.4 1.10 ± 0.03
prek-head run --dry-run --all-files 7.2 ± 0.1 7.0 7.5 1.00
Meta Hooks Performance

Benchmarking meta hooks separately:

prek run check-hooks-apply --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-hooks-apply --all-files 8.7 ± 0.2 8.5 9.1 1.03 ± 0.03
prek-head run check-hooks-apply --all-files 8.5 ± 0.2 8.2 9.1 1.00

prek run check-useless-excludes --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-useless-excludes --all-files 8.7 ± 0.1 8.4 9.1 1.03 ± 0.03
prek-head run check-useless-excludes --all-files 8.5 ± 0.2 8.2 8.7 1.00

prek run identity --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run identity --all-files 7.5 ± 0.1 7.3 7.7 1.03 ± 0.02
prek-head run identity --all-files 7.3 ± 0.1 7.1 7.5 1.00

@will-wright-eng

Copy link
Copy Markdown
Contributor Author

@j178 looks like the changes passes ci -- let me know if there's anything else you'd like to see

@j178 j178 changed the title fix(node-hooks): Scrub git repo-location env vars from spawned subprocesses Isolate npm installs from inherited Git repository state Aug 8, 2026
@j178 j178 added the bug Something isn't working label Aug 8, 2026
@j178 j178 changed the title Isolate npm installs from inherited Git repository state Isolate dependency installs from inherited Git repository state Aug 8, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 52ef6aadd0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/prek/src/languages/node/node.rs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 82600f01d9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/prek/src/git.rs
Comment thread crates/prek/src/git.rs
@j178
j178 force-pushed the fix/scrub-git-repo-env-var branch from 82600f0 to 6fa029d Compare August 8, 2026 14:20

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6fa029daa9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/prek/src/git.rs
@j178
j178 merged commit 88c3463 into j178:master Aug 8, 2026
35 checks passed
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Aug 11, 2026
This MR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [prek](https://github.com/j178/prek) | tools | patch | `0.4.10` → `0.4.13` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>j178/prek (prek)</summary>

### [`v0.4.13`](https://github.com/j178/prek/blob/HEAD/CHANGELOG.md#0413)

[Compare Source](j178/prek@v0.4.12...v0.4.13)

Released on 2026-08-10.

##### Highlights

##### Manage hook tools with mise

The new `language: mise` support lets hooks install tools using
[`mise`](https://mise.jdx.dev/) in an isolated environment:

```yaml
repos:
  - repo: local
    hooks:
      - id: golangci-lint
        name: golangci-lint
        language: mise
        additional_dependencies: ["aqua:golangci/golangci-lint@2"]
        entry: golangci-lint run --fast-only ./...
        pass_filenames: false
```

##### Run commands in hook environments

The new `prek exec` subcommand can run an explicit command in a configured
hook's prepared environment. For example, the hook above makes its managed
binary available to this command:

```console
$ prek exec golangci-lint -- golangci-lint --version
```

##### Enhancements

- Add `mise` language support ([#&#8203;2540](j178/prek#2540))
- Add `deny-filename-pattern` and `require-filename-pattern` hooks ([#&#8203;2488](j178/prek#2488))
- Add `prek exec` for running commands in a hook environment ([#&#8203;2478](j178/prek#2478))
- Add `yaml-language-server:` comment to YAML sample config ([#&#8203;2486](j178/prek#2486))
- Make `prek cache size` output terminal-aware ([#&#8203;2508](j178/prek#2508))
- Match file regexes against path bytes ([#&#8203;2541](j178/prek#2541))
- Show hook aliases in run output ([#&#8203;2497](j178/prek#2497))
- Show hook descriptions in run output ([#&#8203;2490](j178/prek#2490))

##### Performance

- Avoid env cache scans for skipped hooks ([#&#8203;2502](j178/prek#2502))
- Cache Node version queries ([#&#8203;2500](j178/prek#2500))

##### Bug fixes

- Fix Node hook installation with npm 11 ([#&#8203;2487](j178/prek#2487))
- Isolate dependency installs from inherited Git repository state ([#&#8203;2506](j178/prek#2506))

##### Documentation

- Document combined group filtering ([#&#8203;2495](j178/prek#2495))
- Explain what prek does in README ([#&#8203;2507](j178/prek#2507))
- Refresh "Why prek" highlights ([#&#8203;2474](j178/prek#2474))

##### Contributors

- [@&#8203;will-wright-eng](https://github.com/will-wright-eng)
- [@&#8203;Repiteo](https://github.com/Repiteo)
- [@&#8203;j178](https://github.com/j178)

### [`v0.4.12`](https://github.com/j178/prek/blob/HEAD/CHANGELOG.md#0412)

[Compare Source](j178/prek@v0.4.11...v0.4.12)

Released on 2026-08-03.

##### Enhancements

- Add `--require-group` for hook group intersections ([#&#8203;2472](j178/prek#2472))
- Align fast-path and builtin pre-commit hooks ([#&#8203;2433](j178/prek#2433))
- Do not shuffle file list for verbose output ([#&#8203;2431](j178/prek#2431))
- Improve top-level command descriptions ([#&#8203;2429](j178/prek#2429))
- Install `uv` from Astral CDN and drop source racing ([#&#8203;2455](j178/prek#2455))
- Make `prek install --force` bypass external hooks paths ([#&#8203;2437](j178/prek#2437))
- Show builtin hook flags in verbose list output ([#&#8203;2427](j178/prek#2427))
- Verify uv release archive checksums ([#&#8203;2456](j178/prek#2456))

##### Performance

- Precompute file tags in parallel ([#&#8203;2440](j178/prek#2440))
- Skip diffs after known hook modifications ([#&#8203;2447](j178/prek#2447))
- Skip worktree diffs for read-only languages ([#&#8203;2432](j178/prek#2432))
- Track builtin hook file changes directly ([#&#8203;2404](j178/prek#2404))

##### Bug fixes

- Use full object IDs in diff snapshots ([#&#8203;2448](j178/prek#2448))

##### Documentation

- Add a multi-repository configuration example ([#&#8203;2434](j178/prek#2434))
- Rewrite benchmark documentation ([#&#8203;2469](j178/prek#2469))

##### Contributors

- [@&#8203;j178](https://github.com/j178)
- [@&#8203;BitWeaverDev](https://github.com/BitWeaverDev)
- [@&#8203;allanlewis](https://github.com/allanlewis)

### [`v0.4.11`](https://github.com/j178/prek/blob/HEAD/CHANGELOG.md#0411)

[Compare Source](j178/prek@v0.4.10...v0.4.11)

Released on 2026-07-25.

##### Highlights

- This release adds two new builtin hooks, `deny-pattern` and `require-pattern`,
  as native alternatives for `pygrep` use cases. `deny-pattern` fails when a
  configured pattern is found, while `require-pattern` ensures every selected
  file contains a match. By matching natively without spawning a Python
  subprocess, they run over 4x faster than `pygrep` in benchmarks. Note that
  they use
  [Rust `regex` syntax](https://docs.rs/regex/latest/regex/#syntax), which does
  not support look-around features such as negative lookbehind.

- `prek run` now supports `--glob <PATTERN>` to run hooks on tracked files
  matching a glob. It can be repeated or combined with `--files` and
  `--directory`.

- Hook priorities now support reusable aliases:

  ```toml
  [priorities]
  checks = 10

  [[repos]]
  repo = "builtin"
  hooks = [
    { id = "check-json", priority = "checks" },
    { id = "check-yaml", priority = "checks" },
  ]
  ```

  This makes parallel scheduling easier to read and maintain.

##### Enhancements

- Add `deny-pattern` and `require-pattern` builtin hooks ([#&#8203;2359](j178/prek#2359))
- Support `--glob` patterns in `prek run` ([#&#8203;2381](j178/prek#2381))
- Support reusable aliases for hook priorities ([#&#8203;2331](j178/prek#2331))
- Implement `requirements-txt-fixer` as a builtin hook ([#&#8203;2390](j178/prek#2390))
- Improve user-facing warnings and errors ([#&#8203;2380](j178/prek#2380))
- Install Node hooks through git url ([#&#8203;2394](j178/prek#2394))

##### Performance

- Reduce blocking-pool overhead in file hooks ([#&#8203;2384](j178/prek#2384))
- Speed up mixed-line-ending scans with memchr2 ([#&#8203;2391](j178/prek#2391))

##### Bug fixes

- Honor filenames in builtin hook entry and args ([#&#8203;2389](j178/prek#2389))
- Match identify tags across filename parts ([#&#8203;2399](j178/prek#2399))
- Preserve hook output order with a shared pipe ([#&#8203;2385](j178/prek#2385))
- Preserve system download policy when applying metadata ([#&#8203;2395](j178/prek#2395))

##### Contributors

- [@&#8203;j178](https://github.com/j178)
- [@&#8203;chrisoro](https://github.com/chrisoro)

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yODYuMSIsInVwZGF0ZWRJblZlciI6IjQzLjI4OC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiLCJhdXRvbWF0aW9uOmJvdC1hdXRob3JlZCIsImRlcGVuZGVuY3ktdHlwZTo6cGF0Y2giXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node hook install corrupts the user's git index when committing from a linked worktree

2 participants