Add deny-filename-pattern and require-filename-pattern hooks - #2488
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2488 +/- ##
==========================================
+ Coverage 93.59% 93.60% +0.01%
==========================================
Files 131 131
Lines 28275 28342 +67
==========================================
+ Hits 26463 26530 +67
Misses 1812 1812 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds two new builtin hooks (deny-filename-pattern and require-filename-pattern) that validate selected files based on basename regex matching (without reading file contents), enabling generic naming-policy enforcement (including the use case discussed in #2484).
Changes:
- Register new builtin hook IDs in the schema, builtin registry, and
list_builtinsoutputs. - Implement basename-only pattern matching hooks in
builtin_hooks::pattern. - Document both hooks and their arguments/examples in
docs/builtin.md.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
prek.schema.json |
Adds the new builtin hook IDs to the schema enum list. |
docs/builtin.md |
Documents the new hooks, arguments, and examples. |
crates/prek/tests/list_builtins.rs |
Updates expected builtin listing outputs to include the new hooks. |
crates/prek/tests/builtin_hooks.rs |
Adds integration tests for basename-only deny/require filename matching behavior. |
crates/prek/src/hooks/builtin_hooks/pattern.rs |
Implements deny-filename-pattern / require-filename-pattern and shares regex builder logic. |
crates/prek/src/hooks/builtin_hooks/mod.rs |
Wires new hooks into the builtin registry, flags/help, and execution dispatch. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📦 Cargo Bloat ComparisonBinary size change: +0.00% (29.8 MiB → 29.8 MiB) Expand for cargo-bloat outputHead Branch ResultsBase Branch Results |
⚡️ Hyperfine BenchmarksSummary: 0 regressions, 1 improvements above the 10% threshold. Environment
CLI CommandsBenchmarking basic commands in the main repo:
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base --version |
2.3 ± 0.1 | 2.2 | 2.6 | 1.04 ± 0.08 |
prek-head --version |
2.2 ± 0.1 | 2.0 | 3.0 | 1.00 |
prek list
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base list |
9.8 ± 0.7 | 9.3 | 16.1 | 1.04 ± 0.09 |
prek-head list |
9.4 ± 0.4 | 9.1 | 12.1 | 1.00 |
prek validate-config .pre-commit-config.yaml
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base validate-config .pre-commit-config.yaml |
3.4 ± 0.0 | 3.3 | 3.5 | 1.07 ± 0.05 |
prek-head validate-config .pre-commit-config.yaml |
3.2 ± 0.1 | 3.0 | 3.8 | 1.00 |
prek sample-config
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base sample-config |
2.8 ± 1.4 | 2.5 | 12.6 | 1.15 ± 0.58 |
prek-head sample-config |
2.5 ± 0.1 | 2.3 | 2.6 | 1.00 |
✅ Performance improvement for prek sample-config: 13.1800% faster
Cold vs Warm Runs
Comparing first run (cold) vs subsequent runs (warm cache):
prek run --all-files (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
40.4 ± 1.2 | 39.0 | 42.9 | 1.01 ± 0.05 |
prek-head run --all-files |
40.1 ± 1.4 | 38.5 | 42.6 | 1.00 |
prek run --all-files (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
40.1 ± 0.7 | 39.1 | 41.5 | 1.01 ± 0.04 |
prek-head run --all-files |
39.8 ± 1.3 | 37.6 | 41.9 | 1.00 |
Full Hook Suite
Running the builtin hook suite on the benchmark workspace:
prek run --all-files (full builtin hook suite)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
40.0 ± 1.1 | 37.3 | 42.5 | 1.02 ± 0.04 |
prek-head run --all-files |
39.2 ± 1.1 | 36.7 | 41.9 | 1.00 |
Individual Hook Performance
Benchmarking each hook individually on the test repo:
prek run trailing-whitespace --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run trailing-whitespace --all-files |
13.4 ± 0.3 | 12.9 | 14.1 | 1.00 |
prek-head run trailing-whitespace --all-files |
13.5 ± 0.5 | 12.8 | 14.9 | 1.01 ± 0.05 |
prek run end-of-file-fixer --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run end-of-file-fixer --all-files |
11.4 ± 0.3 | 11.0 | 12.1 | 1.01 ± 0.06 |
prek-head run end-of-file-fixer --all-files |
11.3 ± 0.6 | 10.5 | 12.6 | 1.00 |
prek run check-json --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-json --all-files |
8.1 ± 0.2 | 7.7 | 8.7 | 1.03 ± 0.05 |
prek-head run check-json --all-files |
7.9 ± 0.3 | 7.3 | 8.8 | 1.00 |
prek run check-yaml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-yaml --all-files |
7.8 ± 0.1 | 7.5 | 8.1 | 1.02 ± 0.03 |
prek-head run check-yaml --all-files |
7.7 ± 0.1 | 7.5 | 8.0 | 1.00 |
prek run check-toml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-toml --all-files |
8.0 ± 0.3 | 7.4 | 8.6 | 1.05 ± 0.04 |
prek-head run check-toml --all-files |
7.6 ± 0.2 | 7.3 | 8.0 | 1.00 |
prek run check-xml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-xml --all-files |
8.1 ± 0.5 | 7.4 | 9.3 | 1.04 ± 0.10 |
prek-head run check-xml --all-files |
7.8 ± 0.6 | 7.2 | 9.5 | 1.00 |
prek run detect-private-key --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run detect-private-key --all-files |
11.4 ± 0.5 | 10.6 | 12.7 | 1.02 ± 0.08 |
prek-head run detect-private-key --all-files |
11.2 ± 0.8 | 10.2 | 13.8 | 1.00 |
prek run fix-byte-order-marker --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run fix-byte-order-marker --all-files |
13.6 ± 0.8 | 12.5 | 15.2 | 1.05 ± 0.08 |
prek-head run fix-byte-order-marker --all-files |
12.9 ± 0.6 | 12.0 | 14.6 | 1.00 |
Installation Performance
Benchmarking hook installation (fast path hooks skip Python setup):
prek install-hooks (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
4.6 ± 0.1 | 4.5 | 4.7 | 1.05 ± 0.02 |
prek-head install-hooks |
4.4 ± 0.1 | 4.3 | 4.4 | 1.00 |
prek install-hooks (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
4.6 ± 0.1 | 4.5 | 4.7 | 1.04 ± 0.02 |
prek-head install-hooks |
4.4 ± 0.1 | 4.3 | 4.5 | 1.00 |
File Filtering/Scoping Performance
Testing different file selection modes:
prek run (staged files only)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run |
24.1 ± 0.3 | 23.6 | 24.7 | 1.00 ± 0.02 |
prek-head run |
24.1 ± 0.4 | 23.5 | 25.2 | 1.00 |
prek run --files '*.json' (specific file type)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --files '*.json' |
5.5 ± 0.1 | 5.3 | 5.7 | 1.07 ± 0.02 |
prek-head run --files '*.json' |
5.1 ± 0.1 | 5.0 | 5.2 | 1.00 |
Workspace Discovery & Initialization
Benchmarking hook discovery and initialization overhead:
prek run --dry-run --all-files (measures init overhead)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --dry-run --all-files |
7.2 ± 0.1 | 7.0 | 7.5 | 1.05 ± 0.03 |
prek-head run --dry-run --all-files |
6.8 ± 0.1 | 6.7 | 7.3 | 1.00 |
Meta Hooks Performance
Benchmarking meta hooks separately:
prek run check-hooks-apply --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-hooks-apply --all-files |
8.4 ± 0.1 | 8.3 | 8.7 | 1.03 ± 0.02 |
prek-head run check-hooks-apply --all-files |
8.2 ± 0.1 | 7.9 | 8.3 | 1.00 |
prek run check-useless-excludes --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-useless-excludes --all-files |
8.4 ± 0.2 | 8.2 | 8.7 | 1.04 ± 0.02 |
prek-head run check-useless-excludes --all-files |
8.1 ± 0.1 | 7.9 | 8.4 | 1.00 |
prek run identity --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run identity --all-files |
7.2 ± 0.1 | 7.1 | 7.4 | 1.03 ± 0.02 |
prek-head run identity --all-files |
7.0 ± 0.1 | 6.9 | 7.3 | 1.00 |
deny-filename-pattern and require-filename-pattern hooks
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Suppressed comments (1)
docs/builtin.md:119
- The linked issue #2484 requests a Rust-native builtin hook
name-tests-test(with specific defaultfilesfilter and naming-mode args). This PR adds genericdeny-filename-pattern/require-filename-patternhooks, but does not addname-tests-testto the builtin registry/schema/docs, so it doesn’t satisfy the issue’s required behavior as written. Either implementname-tests-test(possibly using these helpers) or adjust the PR/issue scope so the mismatch is explicit.
- [`check-vcs-permalinks`](#check-vcs-permalinks) (Ensures that links to VCS websites are permalinks.)
- [`check-yaml`](#check-yaml) (Checks YAML files for parseable syntax.)
- [`check-xml`](#check-xml) (Checks XML files for parseable syntax.)
- [`deny-filename-pattern`](#deny-filename-pattern) (Fails if any selected filename matches a regular expression.)
- [`deny-pattern`](#deny-pattern) (Fails if any file contains a matching regular expression.)
- [`require-filename-pattern`](#require-filename-pattern) (Fails if any selected filename does not match a regular expression.)
- [`require-pattern`](#require-pattern) (Fails if any file does not contain a matching regular expression.)
This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [prek](https://github.com/j178/prek) | tools | patch | `0.4.10` → `0.4.13` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>j178/prek (prek)</summary> ### [`v0.4.13`](https://github.com/j178/prek/blob/HEAD/CHANGELOG.md#0413) [Compare Source](j178/prek@v0.4.12...v0.4.13) Released on 2026-08-10. ##### Highlights ##### Manage hook tools with mise The new `language: mise` support lets hooks install tools using [`mise`](https://mise.jdx.dev/) in an isolated environment: ```yaml repos: - repo: local hooks: - id: golangci-lint name: golangci-lint language: mise additional_dependencies: ["aqua:golangci/golangci-lint@2"] entry: golangci-lint run --fast-only ./... pass_filenames: false ``` ##### Run commands in hook environments The new `prek exec` subcommand can run an explicit command in a configured hook's prepared environment. For example, the hook above makes its managed binary available to this command: ```console $ prek exec golangci-lint -- golangci-lint --version ``` ##### Enhancements - Add `mise` language support ([#​2540](j178/prek#2540)) - Add `deny-filename-pattern` and `require-filename-pattern` hooks ([#​2488](j178/prek#2488)) - Add `prek exec` for running commands in a hook environment ([#​2478](j178/prek#2478)) - Add `yaml-language-server:` comment to YAML sample config ([#​2486](j178/prek#2486)) - Make `prek cache size` output terminal-aware ([#​2508](j178/prek#2508)) - Match file regexes against path bytes ([#​2541](j178/prek#2541)) - Show hook aliases in run output ([#​2497](j178/prek#2497)) - Show hook descriptions in run output ([#​2490](j178/prek#2490)) ##### Performance - Avoid env cache scans for skipped hooks ([#​2502](j178/prek#2502)) - Cache Node version queries ([#​2500](j178/prek#2500)) ##### Bug fixes - Fix Node hook installation with npm 11 ([#​2487](j178/prek#2487)) - Isolate dependency installs from inherited Git repository state ([#​2506](j178/prek#2506)) ##### Documentation - Document combined group filtering ([#​2495](j178/prek#2495)) - Explain what prek does in README ([#​2507](j178/prek#2507)) - Refresh "Why prek" highlights ([#​2474](j178/prek#2474)) ##### Contributors - [@​will-wright-eng](https://github.com/will-wright-eng) - [@​Repiteo](https://github.com/Repiteo) - [@​j178](https://github.com/j178) ### [`v0.4.12`](https://github.com/j178/prek/blob/HEAD/CHANGELOG.md#0412) [Compare Source](j178/prek@v0.4.11...v0.4.12) Released on 2026-08-03. ##### Enhancements - Add `--require-group` for hook group intersections ([#​2472](j178/prek#2472)) - Align fast-path and builtin pre-commit hooks ([#​2433](j178/prek#2433)) - Do not shuffle file list for verbose output ([#​2431](j178/prek#2431)) - Improve top-level command descriptions ([#​2429](j178/prek#2429)) - Install `uv` from Astral CDN and drop source racing ([#​2455](j178/prek#2455)) - Make `prek install --force` bypass external hooks paths ([#​2437](j178/prek#2437)) - Show builtin hook flags in verbose list output ([#​2427](j178/prek#2427)) - Verify uv release archive checksums ([#​2456](j178/prek#2456)) ##### Performance - Precompute file tags in parallel ([#​2440](j178/prek#2440)) - Skip diffs after known hook modifications ([#​2447](j178/prek#2447)) - Skip worktree diffs for read-only languages ([#​2432](j178/prek#2432)) - Track builtin hook file changes directly ([#​2404](j178/prek#2404)) ##### Bug fixes - Use full object IDs in diff snapshots ([#​2448](j178/prek#2448)) ##### Documentation - Add a multi-repository configuration example ([#​2434](j178/prek#2434)) - Rewrite benchmark documentation ([#​2469](j178/prek#2469)) ##### Contributors - [@​j178](https://github.com/j178) - [@​BitWeaverDev](https://github.com/BitWeaverDev) - [@​allanlewis](https://github.com/allanlewis) ### [`v0.4.11`](https://github.com/j178/prek/blob/HEAD/CHANGELOG.md#0411) [Compare Source](j178/prek@v0.4.10...v0.4.11) Released on 2026-07-25. ##### Highlights - This release adds two new builtin hooks, `deny-pattern` and `require-pattern`, as native alternatives for `pygrep` use cases. `deny-pattern` fails when a configured pattern is found, while `require-pattern` ensures every selected file contains a match. By matching natively without spawning a Python subprocess, they run over 4x faster than `pygrep` in benchmarks. Note that they use [Rust `regex` syntax](https://docs.rs/regex/latest/regex/#syntax), which does not support look-around features such as negative lookbehind. - `prek run` now supports `--glob <PATTERN>` to run hooks on tracked files matching a glob. It can be repeated or combined with `--files` and `--directory`. - Hook priorities now support reusable aliases: ```toml [priorities] checks = 10 [[repos]] repo = "builtin" hooks = [ { id = "check-json", priority = "checks" }, { id = "check-yaml", priority = "checks" }, ] ``` This makes parallel scheduling easier to read and maintain. ##### Enhancements - Add `deny-pattern` and `require-pattern` builtin hooks ([#​2359](j178/prek#2359)) - Support `--glob` patterns in `prek run` ([#​2381](j178/prek#2381)) - Support reusable aliases for hook priorities ([#​2331](j178/prek#2331)) - Implement `requirements-txt-fixer` as a builtin hook ([#​2390](j178/prek#2390)) - Improve user-facing warnings and errors ([#​2380](j178/prek#2380)) - Install Node hooks through git url ([#​2394](j178/prek#2394)) ##### Performance - Reduce blocking-pool overhead in file hooks ([#​2384](j178/prek#2384)) - Speed up mixed-line-ending scans with memchr2 ([#​2391](j178/prek#2391)) ##### Bug fixes - Honor filenames in builtin hook entry and args ([#​2389](j178/prek#2389)) - Match identify tags across filename parts ([#​2399](j178/prek#2399)) - Preserve hook output order with a shared pipe ([#​2385](j178/prek#2385)) - Preserve system download policy when applying metadata ([#​2395](j178/prek#2395)) ##### Contributors - [@​j178](https://github.com/j178) - [@​chrisoro](https://github.com/chrisoro) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yODYuMSIsInVwZGF0ZWRJblZlciI6IjQzLjI4OC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiLCJhdXRvbWF0aW9uOmJvdC1hdXRob3JlZCIsImRlcGVuZGVuY3ktdHlwZTo6cGF0Y2giXX0=-->
Automated mise tool upgrades from local config. Updated tools: - `prek` Command: `mise upgrade --bump --local prek` <details> <summary>Version changelog (prek)</summary> | Tool | Requested | Installed | |------|-----------|-----------| | `prek` | `0.4.11` → `0.4.13` | `0.4.11` → `0.4.13` | </details> <details> <summary>Release notes (1 tools)</summary> <details> <summary>prek: `0.4.11` → `0.4.13` (j178/prek)</summary> ### v0.4.12 ## Release Notes Released on 2026-08-03. ### Enhancements - Add `--require-group` for hook group intersections ([#2472](j178/prek#2472)) - Align fast-path and builtin pre-commit hooks ([#2433](j178/prek#2433)) - Do not shuffle file list for verbose output ([#2431](j178/prek#2431)) - Improve top-level command descriptions ([#2429](j178/prek#2429)) - Install `uv` from Astral CDN and drop source racing ([#2455](j178/prek#2455)) - Make `prek install --force` bypass external hooks paths ([#2437](j178/prek#2437)) - Show builtin hook flags in verbose list output ([#2427](j178/prek#2427)) - Verify uv release archive checksums ([#2456](j178/prek#2456)) ### Performance - Precompute file tags in parallel ([#2440](j178/prek#2440)) - Skip diffs after known hook modifications ([#2447](j178/prek#2447)) - Skip worktree diffs for read-only languages ([#2432](j178/prek#2432)) - Track builtin hook file changes directly ([#2404](j178/prek#2404)) ### Bug fixes - Use full object IDs in diff snapshots ([#2448](j178/prek#2448)) ### Documentation - Add a multi-repository configuration example ([#2434](j178/prek#2434)) - Rewrite benchmark documentation ([#2469](j178/prek#2469)) ### Contributors - @j178 - @BitWeaverDev - @allanlewis ## Install prek 0.4.12 ### Install prebuilt binaries via shell script ```sh curl --proto '=https' --tlsv1.2 -LsSf https://github.com/j178/prek/releases/download/v0.4.12/prek-installer.sh | sh ``` ### Install prebuilt binaries via powershell script ```sh powershell -ExecutionPolicy Bypass -c "irm https://github.com/j178/prek/releases/download/v0.4.12/prek-installer.ps1 | iex" ```… (truncated) ### v0.4.13 ## Release Notes Released on 2026-08-10. ### Highlights #### Manage hook tools with mise The new `language: mise` support lets hooks install tools using [`mise`](https://mise.jdx.dev/) in an isolated environment: ```yaml repos: - repo: local hooks: - id: golangci-lint name: golangci-lint language: mise additional_dependencies: ["aqua:golangci/golangci-lint@2"] entry: golangci-lint run --fast-only ./... pass_filenames: false ``` #### Run commands in hook environments The new `prek exec` subcommand can run an explicit command in a configured hook's prepared environment. For example, the hook above makes its managed binary available to this command: ```console $ prek exec golangci-lint -- golangci-lint --version ``` ### Enhancements - Add `mise` language support ([#2540](j178/prek#2540)) - Add `deny-filename-pattern` and `require-filename-pattern` hooks ([#2488](j178/prek#2488)) - Add `prek exec` for running commands in a hook environment ([#2478](j178/prek#2478)) - Add `yaml-language-server:` comment to YAML sample config ([#2486](j178/prek#2486)) - Make `prek cache size` output terminal-aware ([#2508](j178/prek#2508)) - Match file regexes against path bytes ([#2541](j178/prek#2541)) - Show hook aliases in run output ([#2497](j178/prek#2497)) - Show hook descriptions in run output ([#2490](j178/prek#2490)) ### Performance - Avoid env cache scans for skipped hooks ([#2502](j178/prek#2502)) - Cache Node version queries ([#2500](j178/prek#2500)) ### Bug fixes - Fix Node hook installation with npm 11 ([#2487](j178/prek#2487)) - Isolate dependency installs from inherited Git repository state ([#2506](https://github.com/j178/prek/pull/25… (truncated) </details> </details> Modified files: - `.mise.toml` Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Add generic
deny-filename-patternandrequire-filename-patternhooks for basename-only regex validation, covering the use case discussed in #2484.