Repository navigation
fix(provider-command-code): drop provider-owned system prompt for llm-router 1.4.13 - #909
Merged
Merged
Conversation
…-router 1.4.13 MOT-4542 removed ProviderDeclaration.system_prompt; this provider merged after that refactor still declaring it. Also syncs provider-integration-testkit Cargo.lock path-dep versions so the contract gate passes --locked.
rohitg00
added
the
no-ticket
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
skill-check — worker0 verified, 64 skipped (no docs/).
Four for four. Nicely done. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release run 32714463600 for
provider-command-code/v0.1.2-experimentalfailed on every binary target:MOT-4542 (#891) removed
ProviderDeclaration.system_promptand every provider'sprompts/identity.txt. #883 branched before that refactor and its CI ran on the stale merge base, so provider-command-code landed still declaring the field and does not compile against llm-router 1.4.13 on main. (#907 fixed the lockfile half; this is the remaining source half — it was pushed to that branch minutes after the merge.)Changes, same shape as #891 applied to the other providers:
system_promptdeclaration fromsrc/register.rsand thedeclaration_ships_the_identity_prompttest.provider-command-code/prompts/identity.txt.crates/provider-integration-testkit/Cargo.lockpath-dep versions (9 stale entries,provider-command-codenow0.1.2-experimental) so the provider contract gate passes--locked.Verified locally on rustc 1.97.1 (CI toolchain):
cargo fmt --check,cargo clippy --all-targets --locked -- -D warnings,cargo test --locked, andcargo metadata --lockedfor both lockfiles.After merge the release needs a fresh re-request through Release Control (next version); tags
provider-command-code/v0.1.1-experimentalandv0.1.2-experimentalplus the v0.1.2 GitHub Release point at broken trees and are candidates for cleanup.