Conversation
- What: Added global loading indicator (presentLoader/dismissLoader) to `brokerShipGroup` and `cancelOrderItems` in OrderDetail. - Why: Previously, after confirming these actions in a modal/alert, the UI would sit with no visual feedback while the network request processed, potentially causing user confusion. - Accessibility: Provides system status visibility for assistive technologies and sighted users alike during longer operations. Co-authored-by: dt2patel <60128132+dt2patel@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0bee902e2b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const { data: routingGroupId } = await modal.onWillDismiss(); | ||
| if (!routingGroupId) return; | ||
| try { | ||
| emitter.emit('presentLoader', { message: 'Brokering ship group...' }); |
There was a problem hiding this comment.
Add both Brokering ship group... and the Canceling items... message below to src/locales/en-US.json and src/locales/es-ES.json. App.vue passes loader messages through translate(), but neither key exists in the only locale bundles loaded by src/locales/index.ts, so non-English sessions fall back to raw English and translation tooling cannot supply localized loading feedback.
Useful? React with 👍 / 👎.
|
Closing: the code this patched moved to useOrderActions in #534. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
1 participant
Added missing loading states for async actions after modals are dismissed on
OrderDetail.vue.PR created automatically by Jules for task 478152480746139886 started by @dt2patel