refactor(order-detail): split OrderDetail into Vue-native components with parity to main

[dt2patel]

Summary

Splits the 4,081-line OrderDetail.vue into a composition shell plus focused, Vue-native pieces, with no behaviour change from main apart from the bug fixes listed below.

Piece	Owns
views/OrderDetail.vue (364 lines)	Loading, selection state, Shopify link, exchange lineage, wiring
components/orders/OrderSummaryHeader.vue	Header, timeline, customer/source/identification/attribute/risk cards
components/orders/OrderItemsSegment.vue	Items tab, payments and totals
components/orders/OrderShipGroupCard.vue	One ship group: lifecycle, options, fulfillment, and the inline editors' drafts (saves are emitted)
components/orders/OrderHoldsSegment.vue, OrderCommsSegment.vue	Holds and Comms tabs
composables/useOrderActions.ts	Every page action, and the one validator path that gates them
composables/useOrderDistances.ts	Ship-to distance per brokered group
utils/orderDetailEnrichment.ts	The page view model, built on the store's existing getters

Children take order/shipGroup props, derive with computed, report intent with defineEmits, and import translate and the formatters. Selection flows through v-model. Date, adjustment and product-identity helpers each live in one module (utils/orderDetailDates.ts, utils/orderAdjustments.ts, composables/useProductIdentity.ts), and the card-header grid is shared via <style scoped src>.

src/ goes from 36,347 lines on main to 34,987.

Deliberate differences from main (bug fixes)

• POS issuance badge works:
  • Main asked oms/inventoryItem/detail?orderId=, which is not mounted (405), so a POS-completed item never showed whether inventory left the books.
  • The page now reads each line's inventory item from oms/productFacilities, then its issuance rows from oms/inventoryItem/{id}/detail?orderId=. No backend change is needed.
  • On rails-uat, 159552 shows "Inventory issued, On hand at sale 0 → -1" and 159415 shows "-36 → -37".
• One Shopify link path:
  • The oms/orders/{id}/shopifyShopOrder lookup 404'd on every order load: hotwax/oms#798 and #800 closed unmerged, and hotwax/mantle-shopify-connector#381 is open.
  • It is removed. The Admin link comes only from the product-store inference, which already produced every link main shows.
• Timeline scope: "First Brokered" and the exchange sources read this order's own data. Main read whichever order was loaded last, so a cached page could show another order's dates.
• Timeline refresh: the fulfillment timeline now refreshes after an action (broker, release, …), not only on first load.
• Facility lookups: each facility's address is requested once per session, misses included. Main re-requested it on every recompute, 4 times per load on rails-uat.
• Carrier selection: a carrier picked while choosing a method now resets only when the saved carrier or method changes, not on any unrelated data refresh.
• UI text: · is removed from the ship group summary and the hold-task ship group labels, per the AccxUI rules. Time-difference units and the "Customer name" placeholder are now translated.

Removed: unreachable footer actions and dead code

• Return, Appeasement, Reship and Clone:
  • The validator modelled all four footer actions, but none could render. Return was hidden by HIDE_SHOPIFY_UNSYNCED_ACTIONS, Appeasement and Reship had no handler, and Clone was hidden in 469a024.
  • Their gates and handlers are removed, along with CloneOrderModal.vue, utils/cloneOrder.ts and its spec.
  • Tracked in Returns, RMA, exchange, and refund lifecycle workspace #6 (returns), Offer Appeasement from the order detail footer #554 (Appeasement), Offer Reship from the order detail footer #555 (Reship) and Bring back Clone order on the order detail footer #556 (Clone). The last working Clone is at 8d5ab9a.
  • The Appeasement backend already exists: POST oms/returns/appeasementReturn. See Offer Appeasement from the order detail footer #554.
• Validator: the unused discovery helpers are gone (getFooterActions, getShipGroupActions, getItemActions, getBulkSelectableItems, isItemSelectable, hasAnyCompletedItem, ctx.allItems).
• Store: the "current order" layer is gone (currentOrderId and 22 unscoped getters that only tests read), plus the order work-effort fetch, the commEvents mirror and the unread risk error state.
• Park, pull back and release share one flow in useOrderActions (validate, pick the eligible items, prompt, call, clear the selection, toast, reload). The allocation call and the task payload are shared too.
• Item rows: each item row's props and listeners are bound from one object, so the single-item row and the rolled-up child rows no longer repeat 13 bindings. The Request transfer and Cancel buttons stay in the row's actions slot.
• Ship group edits: the card no longer writes. It keeps its drafts and emits save-fields / save-address; useOrderActions saves, toasts and reloads like every other action, and owns which editor is open (v-model:editor), so an editor closes only when its save succeeds and a failed save keeps the draft on screen, as on main. The address save re-checks the validator like the other handlers, and each editor's Save button is disabled while a save is in flight.
• Store reads go through getters: the page no longer reads the order detail store's state directly. New pendingById gives one definition of "not answered yet" (the exchange Source card had its own inline version, which differed from loadingById); commEventsForOrder and riskAssessmentsForOrder return [] when nothing is loaded; the exchange return links use the existing orderById.

Behaviour compared against main on rails-uat

The same 16 orders were loaded in both builds side by side and compared section by section (header, Items, Shipgroups, Holds, Comms, footer, and the enabled/disabled state of every control). Every section matched except the · separator. The orders covered:

• approved orders, brokered and parked
• completed orders with returns
• open orders with cancelled items
• POS orders
• exchanges and their originals
• a Created order
• risk-flagged orders
• orders with hold, swap and fraud tasks
• the brokering queue

Also verified:

• Layout: computed layout is identical at 1440 px and 390 px.
• Actions: every action button opens the same modal or alert with the same props as main. Modals were stubbed, so nothing was submitted.
• Card interactions: expand, item selection and carrier change match main.
• Network: a Web order makes 12 API calls vs 15 on main. There's no issuance call (a 405 on rails-uat) and no duplicate facility lookups.
• Second pass (this update): 10 orders were compared again, including POS orders 159552 and 159415. The only differences are the separator, the working issuance badge, and the two failing calls (404 and 405) that are now gone. The Shopify Admin link resolves to the same URL on both, for example admin.shopify.com/store/rails-25/orders/7163180122281 for 115548.
• Ship group editors: with every write faked in the browser (nothing reached rails-uat), gift message, shipping dates and address behave the same as main on 104848: identical request payloads, a failed save keeps the editor and draft open with the failure toast, a successful save closes it. The Items tab rows are byte-identical to main on 104821, 115548, 157940 and 159552.
• Store getters: Comms (160791, 160806) and the risk details modal's data (160791: 1 assessment / 9 facts; 160802: 1 / 2) match main. The exchange Source card cannot be exercised on rails-uat, whose order document carries no itemAssocs; pendingById is equivalent to the inline check it replaces because every store entry is created with a status.
• Selection actions: park, pull back and release have a new spec that mocks the API and modals. It asserts the exact requests, and it passes unchanged against the previous implementation too.

Checks

• vitest: 85 files / 495 tests pass. The count dropped because the Clone spec was removed with the feature; new specs cover the issuance lookup and the selection actions.
• vue-tsc --ignoreDeprecations 6.0: 34 errors (main: 50), none in the files this PR touches.
• vite build passes.

Not verifiable on rails-uat: distances, because no facility there has a postal address. The new unit test covers it.

🤖 Generated with Claude Code

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-20T05:41:19.641533Z	6fbd21d	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6fbd21d0a5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".