[minatoaquaMK2]

Named terminal and agent lookup scans the terminal registry for every pane candidate. Use borrowed string keys in the existing HashMap to reduce that join from O(P×T) to expected O(P), preserving target precedence, pane order, detached-terminal exclusion and ambiguity handling.

Release builds on Apple M3 / 24 GiB, macOS 27.0, Rust 1.96.1; medians of three serial runs with alternating baseline/candidate order, compared with upstream fff6c820. Time reduction = (before − after) / before × 100%.

Panes	Terminal name (µs), before → after	Time reduction	Agent name (µs), before → after	Time reduction
15	5.436 → 1.938	64.35%	4.421 → 1.079	75.59%
128	295.406 → 13.499	95.43%	275.303 → 7.372	97.32%
512	3808.354 → 54.401	98.57%	3682.549 → 30.925	99.16%

Reproduce: just bench-terminal-targets. Tests cover borrowed-key lookup after serialization and adversarial pane/tab identities. Native just ci, just docs-contract-test, and GitHub Linux/macOS/Windows CI passed.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)

• ai-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: c44505f8-a1d6-429e-b852-ec38a949c660

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 61b42f6e-ffe5-422e-8d1c-513114fd964b

📥 Commits

Reviewing files that changed from the base of the PR and between fff6c82 and 623fbbe.

📒 Files selected for processing (3)

• justfile
• src/app/terminal_targets.rs
• src/terminal/id.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

Terminal IDs now support borrowed string lookups in maps. Terminal target matching and validation retrieve terminals directly by ID. Added tests cover resolution after pane and tab reordering, detached terminals, shared-name ambiguity, and lookup profiling. A justfile recipe runs the ignored profile test in release mode.

Suggested reviewers: ogulcancelik

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to 623fb

The terminal lookup optimization is mergeable after normal checks; no actionable risk remains identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 36.36% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 2 files. (1 skipped: …	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly and concisely describes the main change: using keyed terminal lookup to improve named-target performance.
Description check	✅ Passed	The description directly explains the lookup optimization, preserved behavior, benchmark results, test coverage, and validation status.

Full details: Docstring Coverage

Explanation

Docstring coverage is 36.36% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 2 files. (1 skipped: 1 unsupported.)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[kangal-bot]

@coderabbitai review
@greptileai

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[greptile-apps]

Confidence Score: 5/5

[Medium risk] Optimizes terminal target lookup with keyed access.

The PR appears safe to merge; no actionable issue was identified in its changes.

Summary

The PR replaces repeated terminal-registry scans with borrowed-key lookups for named terminal and agent targets.

• Adds tests for restored terminal IDs, reordered pane identities, ambiguity, and detached-terminal exclusion.
• Adds an opt-in scaling profile.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Input[Target string] --> Panes[Enumerate attached panes]
  Panes --> Lookup[Look up terminal by borrowed ID]
  Lookup --> Match[Match agent name or label]
  Match --> Result[Resolve one, report ambiguity, or return not found]

Loading

_{Reviews (3) · Last reviewed commit: "perf: use keyed terminal lookup for name..."}

[JJLiebig]

@greptileai

[JJLiebig]

Rebased onto current master (21d71a03); final head is clean (Linux/macOS/Windows CI green).

The Borrow<str> impl is sound: TerminalId is a String newtype whose derived Hash/Eq delegate to str, so terminals.get(id.as_str()) resolves the same entry that was inserted as TerminalId. The three converted lookups keep target precedence, pane order, detached-terminal exclusion and ambiguity handling, which the new tests exercise.

Windows benchmark (x86_64-pc-windows-msvc, rustc 1.96.1, release, median of 7 samples, just bench-terminal-targets), before -> after:

panes	terminal name	agent name
1	0.384 -> 0.360 us	0.285 -> 0.223 us
15	6.999 -> 2.643 us (-62%)	5.745 -> 1.501 us (-74%)
128	346.4 -> 20.6 us (-94%)	339.5 -> 12.7 us (-96%)
512	4846.5 -> 88.7 us (-98%)	4886.0 -> 49.2 us (-99%)

Note on the Greptile summary: it flags agent-session restore / configured-shell reporting, but neither is in this PR's diff (3 files: justfile, src/app/terminal_targets.rs, src/terminal/id.rs). Those behaviors come from unrelated master commits that entered the compare range after the rebase; there are no inline findings on this change.

Approving.

[JJLiebig]

@greptileai