Repository navigation
obk retire removes a bot's project on the Orca release that guards setup-delete (#528) - #535
Conversation
…tup-delete (#528) Orca's next release (stablyai/orca#27172) refuses a plain project setup-delete of a project with saved workspace details or live terminals. A bot's project keeps saved details after its tabs close. obk retire --bot now sends --force, after its own checks: the project is the bot's own, and the kit closed the tabs the book names. Orca 1.4.223 refuses --force as an unknown flag and changes nothing; then the kit sends the plain delete. Every other refusal is reported as before. Tier: 0 — obk retire keeps removing a bot's Orca project on the Orca release that guards setup-delete Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
For the follow-up on the system tests' cleanup (the architect's request): The system tests already import from |
|
No findings against issue #528 or the changed code. Reviewed Checked the sole Read Orca at Local checks used Node v26.11.1 and a hard 1800-second process limit:
Set aside: the fake's empty error CI currently has seven successful test shards and two active shards. AssuredLoop and CodeQL passed. The merge must wait for the remaining checks. I did not load or run VERDICT: APPROVED |
Closes #528.
What changed
deleteProjectinsrc/orca.jssendsorca project setup-delete --setup <id> --force. Its only caller isobk retire --bot. That command checks first that every tab in the project is one the book names. Then it closes those tabs and waits until Orca no longer lists them. Only then does it delete.--forcewithinvalid_argument"Unknown flag --force", the kit sends the plain delete. Orca 1.4.223 gives this refusal. Every other refusal is reported as before, and the kit does not delete some other way.docs/tech-notes.mdrecords the guard and the 1.4.223 refusal. Item 12 in "Live checks still owed" is new.Orca's guard (boundary 1, read in Orca's code at
cb69d52455, no build or run)--force, the new CLI sendsforce: false. Then the runtime refuses a repo-backed project that has terminals not known to have exited, or saved metadata for any of its workspaces. The refusal isruntime_error: "This project has … Re-run with --force to remove it anyway."--forceskips the whole check. A client that sends noforcekey is not checked.git tag --contains cb69d52455gives nothing, and v1.4.224 is the newest tag.Orca 1.4.223 (boundary 3)
src/cli/args.ts), and--forceis not an allowed flag ofsetup-delete.orca project setup-delete --setup obk-probe-528-no-such-setup --force --jsongaveok: false,code: invalid_argument, messageUnknown flag --force for command: project setup-delete, andruntimeId: null. Nothing was deleted. The architect was told first, and~/.claude.jsonand~/.codex/config.tomlwere compared after the probe.Tests (boundary 4)
A separate subagent wrote the tests from the issue and the public interface. I did not change them.
test/helpers/fake-orca.jshas two new state keys:deleteGuard(the new Orca) andforceUnknown(1.4.223). With neither key, the fake behaves as before.test/retire-orca-guard.test.js:test/orca-fake.test.js: three new tests check the fake's new keys.retire-orca-guard11/11,retire33/33. More results follow in a comment.Not done here
setup-delete. On the new release that cleanup will be refused. This is outside the kit's own removal and outside this issue. I will tell the architect.Tier: 0 — obk retire keeps removing a bot's Orca project on the Orca release that guards setup-delete
🤖 Generated with Claude Code