Skip to content

feat!: upgrade minimum Node.js version to 22 - #9357

Merged
danieljbruce merged 4 commits into
mainfrom
upgrade-generated-packages-again
Sep 16, 2026
Merged

danieljbruce merged 4 commits into
mainfrom
upgrade-generated-packages-again

Conversation

@danieljbruce

Copy link
Copy Markdown
Contributor

Description

Upgrade some generated packages recently written by librarian to node 22 that were written for Node 18 by mistake.

Impact

Ensure that all generated packages are on Node version 18.

@danieljbruce
danieljbruce requested a review from a team as a code owner September 16, 2026 20:36
@github-actions
github-actions Bot requested a review from feywind September 16, 2026 20:37

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependencies, including google-gax and gapic-tools, and bumps the minimum Node.js engine version to >=22 across multiple package.json files. The reviewer pointed out that these packages are auto-generated by librarian, meaning manual edits will be overwritten during the next regeneration. To prevent this, these changes should be applied upstream in the generator or templates, or the files should be added to the keep list in librarian.yaml.

Comment thread packages/google-cloud-apptopology/package.json
Comment thread packages/google-cloud-ftp/package.json
Comment thread packages/google-cloud-workloadidentity/package.json
Comment thread packages/google-shopping-merchant-loyaltycustomers/package.json
@danieljbruce
danieljbruce enabled auto-merge (squash) September 16, 2026 21:07
@danieljbruce
danieljbruce merged commit d2e6a23 into main Sep 16, 2026
44 checks passed
@danieljbruce
danieljbruce deleted the upgrade-generated-packages-again branch September 16, 2026 21:12
@release-please release-please Bot mentioned this pull request Sep 16, 2026
danieljbruce pushed a commit that referenced this pull request Sep 16, 2026
🤖 I have created a release *beep* *boop*
---


<details><summary>gcp-metadata: 9.0.4</summary>

##
[9.0.4](gcp-metadata-v9.0.3...gcp-metadata-v9.0.4)
(2026-09-16)


### Bug Fixes

* **gcp-metadata:** Support CLOUD_RUN_WORKER_POOL residency detection
and harden isAvailable error unwrapping
([#9349](#9349))
([10b654f](10b654f))
* Update IsGoogleCloudServerless function to check for Cloud Run Worker
Pools
([#9226](#9226))
([e0ff8c5](e0ff8c5))
</details>

<details><summary>apptopology: 0.3.0</summary>

##
[0.3.0](apptopology-v0.2.0...apptopology-v0.3.0)
(2026-09-16)


### ⚠ BREAKING CHANGES

* upgrade minimum Node.js version to 22
([#9357](#9357))

### Features

* Upgrade minimum Node.js version to 22
([#9357](#9357))
([d2e6a23](d2e6a23))
</details>

<details><summary>ftp: 0.3.0</summary>

##
[0.3.0](ftp-v0.2.0...ftp-v0.3.0)
(2026-09-16)


### ⚠ BREAKING CHANGES

* upgrade minimum Node.js version to 22
([#9357](#9357))

### Features

* Upgrade minimum Node.js version to 22
([#9357](#9357))
([d2e6a23](d2e6a23))
</details>

<details><summary>tasks: 7.1.1</summary>

##
[7.1.1](tasks-v7.1.0...tasks-v7.1.1)
(2026-09-16)


### Bug Fixes

* Remove unintentionally added file
([#9356](#9356))
([99f6657](99f6657))
</details>

<details><summary>workloadidentity: 0.3.0</summary>

##
[0.3.0](workloadidentity-v0.2.0...workloadidentity-v0.3.0)
(2026-09-16)


### ⚠ BREAKING CHANGES

* upgrade minimum Node.js version to 22
([#9357](#9357))

### Features

* Upgrade minimum Node.js version to 22
([#9357](#9357))
([d2e6a23](d2e6a23))
</details>

<details><summary>loyaltycustomers: 0.3.0</summary>

##
[0.3.0](loyaltycustomers-v0.2.0...loyaltycustomers-v0.3.0)
(2026-09-16)


### ⚠ BREAKING CHANGES

* upgrade minimum Node.js version to 22
([#9357](#9357))

### Features

* Upgrade minimum Node.js version to 22
([#9357](#9357))
([d2e6a23](d2e6a23))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants