Skip to content

chore: update IsGoogleCloudServerless function to check for Cloud Run Worker Pools - #9226

Merged
quirogas merged 2 commits into
googleapis:mainfrom
kcolton-jpg:patch-2
Sep 15, 2026
Merged

chore: update IsGoogleCloudServerless function to check for Cloud Run Worker Pools#9226
quirogas merged 2 commits into
googleapis:mainfrom
kcolton-jpg:patch-2

Conversation

@kcolton-jpg

@kcolton-jpg kcolton-jpg commented Aug 28, 2026 •
edited by quirogas
Loading

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [ X ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [X ] Ensure the tests and linter pass
  • [ X] Code coverage does not decrease (if any source code was changed)
  • [ X] Appropriate docs were updated (if necessary)

For ##9225 🦕

@kcolton-jpg
Update gcp-residency.ts to include K_CLOUD_RUN_WORKER_POOLS when dete…
42a6ed3 
…rmining if the environment is GCP Serverless

Update the function for determining whether a environment is GCP Serverless to include K_CLOUD_RUN_WORKER_POOLS.
@kcolton-jpg
Update ISGoogleCloudServerless function check for Cloud Run Worker Pools
99458b3
@kcolton-jpg
kcolton-jpg requested a review from a team as a code owner August 28, 2026 21:38
@github-actions
github-actions Bot requested a review from westarle August 28, 2026 21:39
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Aug 28, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the isGoogleCloudServerless detection logic to include the CLOUD_RUN_WORKER_POOL environment variable, along with its corresponding JSDoc documentation. The review feedback correctly identifies an invalid internal URL in the newly added documentation and suggests replacing it with the correct public Google Cloud documentation link.

Comment thread core/packages/gcp-metadata/src/gcp-residency.ts
@quirogas quirogas changed the title Update IsGoogleCloudServerless function to check for Cloud Run Worker Pools chore: update IsGoogleCloudServerless function to check for Cloud Run Worker Pools Sep 15, 2026
quirogas
quirogas approved these changes Sep 15, 2026
View reviewed changes

@quirogas quirogas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

please fix the linter errors before submitting and make sure the commit message follows conventional commit guidelines.

@quirogas
quirogas removed the request for review from westarle September 15, 2026 22:11
@quirogas
quirogas merged commit e0ff8c5 into googleapis:main Sep 15, 2026
49 of 51 checks passed
@quirogas

quirogas commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

We'll address linting issues in follow up PR.

@release-please release-please Bot mentioned this pull request Sep 15, 2026
Merged
This was referenced Sep 15, 2026
Merged
Closed
quirogas added a commit that referenced this pull request Sep 16, 2026
@quirogas
fix(gcp-metadata): support CLOUD_RUN_WORKER_POOL residency detection …
10b654f 
…and harden isAvailable error unwrapping (#9349)

Follow-up to #9226 (Fixes #9225).

Improve error handling and environment detection. Specifically, it handles abort and timeout errors by mapping them to 'ETIMEDOUT', extracts nested error codes from err.error, and formats unexpected error codes more clearly in warnings
danieljbruce pushed a commit that referenced this pull request Sep 16, 2026
@release-please
chore: release main (#9348)
63d5fe9 
🤖 I have created a release *beep* *boop*
---


<details><summary>gcp-metadata: 9.0.4</summary>

##
[9.0.4](gcp-metadata-v9.0.3...gcp-metadata-v9.0.4)
(2026-09-16)


### Bug Fixes

* **gcp-metadata:** Support CLOUD_RUN_WORKER_POOL residency detection
and harden isAvailable error unwrapping
([#9349](#9349))
([10b654f](10b654f))
* Update IsGoogleCloudServerless function to check for Cloud Run Worker
Pools
([#9226](#9226))
([e0ff8c5](e0ff8c5))
</details>

<details><summary>apptopology: 0.3.0</summary>

##
[0.3.0](apptopology-v0.2.0...apptopology-v0.3.0)
(2026-09-16)


### ⚠ BREAKING CHANGES

* upgrade minimum Node.js version to 22
([#9357](#9357))

### Features

* Upgrade minimum Node.js version to 22
([#9357](#9357))
([d2e6a23](d2e6a23))
</details>

<details><summary>ftp: 0.3.0</summary>

##
[0.3.0](ftp-v0.2.0...ftp-v0.3.0)
(2026-09-16)


### ⚠ BREAKING CHANGES

* upgrade minimum Node.js version to 22
([#9357](#9357))

### Features

* Upgrade minimum Node.js version to 22
([#9357](#9357))
([d2e6a23](d2e6a23))
</details>

<details><summary>tasks: 7.1.1</summary>

##
[7.1.1](tasks-v7.1.0...tasks-v7.1.1)
(2026-09-16)


### Bug Fixes

* Remove unintentionally added file
([#9356](#9356))
([99f6657](99f6657))
</details>

<details><summary>workloadidentity: 0.3.0</summary>

##
[0.3.0](workloadidentity-v0.2.0...workloadidentity-v0.3.0)
(2026-09-16)


### ⚠ BREAKING CHANGES

* upgrade minimum Node.js version to 22
([#9357](#9357))

### Features

* Upgrade minimum Node.js version to 22
([#9357](#9357))
([d2e6a23](d2e6a23))
</details>

<details><summary>loyaltycustomers: 0.3.0</summary>

##
[0.3.0](loyaltycustomers-v0.2.0...loyaltycustomers-v0.3.0)
(2026-09-16)


### ⚠ BREAKING CHANGES

* upgrade minimum Node.js version to 22
([#9357](#9357))

### Features

* Upgrade minimum Node.js version to 22
([#9357](#9357))
([d2e6a23](d2e6a23))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quirogas quirogas quirogas approved these changes
@shivanee-p shivanee-p shivanee-p approved these changes
+2 more reviewers
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
@iennae iennae iennae approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kcolton-jpg @quirogas @iennae @shivanee-p