Repository navigation
ci: make Android preview jobs informational, not a merge gate - #91
Merged
Merged
Conversation
Android arm64 is a preview platform (docs/ANDROID.md: physical-device startup validation is still pending), but android-cross was in CI Success's needs, so an Android-only failure blocked every pull request, including ones that do not touch Android code. The October 2026 setup-android breakage (fixed in #85) showed the cost. Remove android-cross from CI Success's needs and its summary. The jobs still run on every PR and their result stays visible. continue-on-error is deliberately not used: it would paint a broken Android build green. Document the policy and the condition for re-gating in ci.yml and docs/ANDROID.md.
kolkov
added
priority: high
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
kolkov
added
area: ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Android arm64 is a preview platform.
docs/ANDROID.md: "physical-device startup validation is still required before this can be described as released Android support". Yet its CI jobs gate every merge:android-crossis inCI Success'sneeds(added with the platform in feat: add Android arm64 Bionic support #62);Android arm64 (Go 1.25.12)andAndroid arm64 (Go 1.26.5)are also required status checks in branch protection.So an Android-only failure blocks all pull requests, including ones that don't touch Android code at all (which is isolated behind
android && arm64build tags). It just happened:android-actions/setup-android@v3requested thetoolspackage, which Google removed from the SDK repository, so both jobs failed in "Set up Android SDK" before any goffi code ran, and that alone left #90 BLOCKED. #85 (now merged) fixes the job itself. The next outside breakage of the Android toolchain would block every PR the same way.Change
ci.yml: removeandroid-crossfromCI Success'sneedsand from its summary output. Add a comment on the job saying it's informational while Android is in preview, why it deliberately does not usecontinue-on-error(that would paint a broken Android build green), and when to put it back (after the physical-device validationdocs/ANDROID.mdrequires).docs/ANDROID.md: one paragraph on the same policy.CHANGELOG.md: entry under[Unreleased] / Changed.The jobs still run on every PR and their result stays visible. Only the gate changes.
Maintainer follow-up
Branch protection still lists both
Android arm64 (Go …)checks as required. They'll be removed from the required set together with this change.cc @besmpl: you maintain the Android platform. This doesn't change the probe or its matrix, only whether it blocks merges during the preview.