Skip to content

ci: stop setup-android from requesting the removed tools package - #85

Merged
kolkov merged 1 commit into
go-webgpu:mainfrom
unxed:feature/ci-setup-android-no-tools
Oct 15, 2026
Merged

kolkov merged 1 commit into
go-webgpu:mainfrom
unxed:feature/ci-setup-android-no-tools

Conversation

@unxed

@unxed unxed commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Both Android arm64 jobs now fail in "Set up Android SDK", before any goffi code runs:

Warning: Failed to find package 'tools'
Error: The process '/usr/local/lib/android/sdk/cmdline-tools/16.0/bin/sdkmanager' failed with exit code 1

android-actions/setup-android@v3 defaults its packages input to tools platform-tools and runs sdkmanager <pkg> for each entry. Google's SDK repository index (repository2-3.xml) no longer contains a tools package, while platform-tools and cmdline-tools are still listed, so the tools call exits 1. The same breakage is tracked upstream in android-actions/setup-android#537. The last green run of these jobs on main was for c8f74c6 on 2026-09-10; the workflow has not changed since, and the failure is identical on a docs-only PR.

Nothing in this workflow or in scripts/check-android-arm64.sh uses the tools package. Pass packages: platform-tools, which keeps everything the step installed before except the package that no longer exists. The action still accepts licenses, exports ANDROID_HOME and puts sdkmanager on PATH, which the following NDK step relies on.

Both Android arm64 jobs now fail in "Set up Android SDK", before any goffi
code runs:

    Warning: Failed to find package 'tools'
    Error: The process '/usr/local/lib/android/sdk/cmdline-tools/16.0/bin/sdkmanager' failed with exit code 1

android-actions/setup-android@v3 defaults its `packages` input to
`tools platform-tools` and runs `sdkmanager <pkg>` for each entry. Google's
SDK repository index (repository2-3.xml) no longer contains a `tools`
package, while `platform-tools` and `cmdline-tools` are still listed, so
the `tools` call exits 1. The same breakage is tracked upstream in
android-actions/setup-android#537. The last green run of these jobs on main
was for c8f74c6 on 2026-09-10; the workflow has not changed since, and the
failure is identical on a docs-only PR.

Nothing in this workflow or in scripts/check-android-arm64.sh uses the
`tools` package. Pass `packages: platform-tools`, which keeps everything
the step installed before except the package that no longer exists. The
action still accepts licenses, exports ANDROID_HOME and puts sdkmanager on
PATH, which the following NDK step relies on.
@unxed
unxed requested a review from kolkov as a code owner September 17, 2026 11:24
@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@kolkov kolkov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks — straightforward and well explained.

Checked: android-actions/setup-android@v3 takes the packages input, nothing in ci.yml or scripts/check-android-arm64.sh uses the obsolete tools package, and both Android arm64 jobs are green on this branch.

Since #83, #84, #87, #88 and #89 all carry this commit, we'll merge this one first so the others shrink to their own changes after a rebase.

LGTM.

@kolkov
kolkov merged commit 22d3db7 into go-webgpu:main Oct 15, 2026
17 checks passed
@kolkov kolkov added area: ci CI workflows, check scripts, branch protection platform: android Android (Bionic) - preview platform labels Oct 15, 2026
kolkov added a commit that referenced this pull request Oct 15, 2026
Android arm64 is a preview platform (docs/ANDROID.md: physical-device
startup validation is still pending), but android-cross was in CI
Success's needs, so an Android-only failure blocked every pull request,
including ones that do not touch Android code. The October 2026
setup-android breakage (fixed in #85) showed the cost.

Remove android-cross from CI Success's needs and its summary. The jobs
still run on every PR and their result stays visible. continue-on-error
is deliberately not used: it would paint a broken Android build green.
Document the policy and the condition for re-gating in ci.yml and
docs/ANDROID.md.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci CI workflows, check scripts, branch protection platform: android Android (Bionic) - preview platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants