Skip to content

TargetSource CRD changes#51

Merged
karimra merged 4 commits into
mainfrom
feature/targetsource-crd-fields
Apr 26, 2026
Merged

TargetSource CRD changes#51
karimra merged 4 commits into
mainfrom
feature/targetsource-crd-fields

Conversation

@mcdillson
Copy link
Copy Markdown
Collaborator

this PR introduces a provider key within the TargetSource spec, so that we're able to differentiate which loader is needed based on the configured provider. there can only be one provider, and the profile field is made compulsory as well (not necessarily the final decision to implement it like this)

@mcdillson mcdillson requested a review from karimra April 15, 2026 15:33
@mcdillson mcdillson self-assigned this Apr 15, 2026
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 17, 2026

Deploying gnmic-operator with  Cloudflare Pages  Cloudflare Pages

Latest commit: b600ffe
Status: ✅  Deploy successful!
Preview URL: https://4b747298.gnmic-operator2.pages.dev
Branch Preview URL: https://feature-targetsource-crd-fie.gnmic-operator2.pages.dev

View logs

@mcdillson
Copy link
Copy Markdown
Collaborator Author

@karimra I went over the kubebuilder validation fields.

  • a combination of MinProperties and MaxProperties didn't work for the provider spec, since this is only for array types. this is now solved with ExactlyOneOf
  • if strings need to be specified and cannot be empty, they have to be annotated with MinLength, because otherwise it's only checked for existence, which it does in all cases, regardless if you add omitempty or not

the two provider specs are just placeholders for now, but show how others would need to be added.

@denyost denyost added the enhancement New feature or request label Apr 24, 2026
@karimra karimra merged commit 4ac6c64 into main Apr 26, 2026
9 checks passed
@denyost denyost deleted the feature/targetsource-crd-fields branch April 30, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants