Feature/target loading architecture#45
Merged
Merged
Conversation
Deploying gnmic-operator with
|
| Latest commit: |
2e863cf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://96a81c91.gnmic-operator2.pages.dev |
| Branch Preview URL: | https://feature-target-loading-archi.gnmic-operator2.pages.dev |
…/target-loading-architecture
Collaborator
karimra
requested changes
Apr 20, 2026
Collaborator
karimra
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the TargetSource loading pipeline within the package
discovery:discovery/coredefines the loader interface and other necessary typesdiscovery/loadershold the implementations for the different loader types, which observe the changes from the target sourcesdiscovery/loader.goserves as the entrypoint, from which the corresponding loader gets calledtarget_manager.goconsumes discovered target snapshots and reconciles them into Kubernetes Target CRs.targetsource_controller.goorchestrates lifecycle management, wiring loaders and target managers together while keeping the reconcile loop focused on start/stop logic only.