docs: add Cypress E2E testing guidelines to README and implementer agents - #4121
priyanshu6238 wants to merge 6 commits into
Conversation
WalkthroughThe changes add a dedicated Cypress test-writer agent, define Cypress handoff rules for the UI implementer, and document Cypress setup and usage in the README. The README also receives navigation, formatting, and spacing updates. Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
priyanshu6238
changed the title
|
🚀 Deployed on https://deploy-preview-4121--glific-frontend.netlify.app |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/agents/ui-implementer.md:
- Around line 108-111: Update the Cypress execution guidance in the agent
instructions so E2E specs are marked pending only when the Elixir backend is
unavailable. Allow the implementer to run yarn cy:open or yarn cy:run when the
backend is running; otherwise, require documenting that execution remains
pending for the e2e-test-engineer agent or a local run.
In `@README.md`:
- Around line 155-156: Update the README’s Glific backend URL to match Cypress’s
configured backendUrl, documenting https://api.glific.test:4001/api instead of
the outdated host and path. If the README URL is intentionally authoritative,
change the Cypress backendUrl configuration instead and keep both references
consistent.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: c0133475-b91b-4fe8-b9d6-61188c199144
📒 Files selected for processing (3)
.claude/agents/ui-consistency-reviewer.md.claude/agents/ui-implementer.mdREADME.md
Glific
 |
||||||||||||||||||||||||||||||
| Project |
Glific
|
| Branch Review |
update/readme_for_frontend
|
| Run status |
|
| Run duration | 11m 02s |
| Commit |
|
| Committer | Priyanshu singh |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
0
|
 |
0
|
 |
66
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
priyanshu6238
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4121 +/- ##
==========================================
+ Coverage 82.16% 82.19% +0.03%
==========================================
Files 346 346
Lines 15131 15119 -12
Branches 3584 3582 -2
==========================================
- Hits 12432 12427 -5
+ Misses 1637 1634 -3
+ Partials 1062 1058 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/agents/cypress-test-writer.md:
- Around line 52-58: Update the Cypress execution guidance in the agent
instructions to prevent full-suite runs: require scoping execution to the
changed spec using the appropriate Cypress spec option, while clarifying that
cy:open only runs after the user selects the spec. Preserve full-suite execution
as the responsibility of the e2e-test-engineer agent.
In @.claude/agents/ui-implementer.md:
- Around line 112-114: Expand the Cypress handoff checklist in the UI
implementer guidance to include changes to existing spec behavior and critical
paths: authentication/login, messaging/chat, flow builder, and CRUD. Preserve
the existing triggers for new pages, dialogs, and multi-step flows, and align
the checklist with the requirements in cypress-test-writer.md.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 770b6782-07c3-40a3-9761-5f274b39163c
📒 Files selected for processing (3)
.claude/agents/cypress-test-writer.md.claude/agents/ui-implementer.mdREADME.md
🚧 Files skipped from review as they are similar to previous changes (1)
- README.md
| --- | ||
|
|
||
| You write Cypress specs for glific-frontend. You do not implement UI and you do not run | ||
| the full e2e suite against a live backend — that's the `ui-implementer` and |
There was a problem hiding this comment.
I think we need to restructure our agents to,
- planner
- implementor
- test-engineer (for both cypress & vitest or can be separate)
- reviewer (for overall quality and accuracy)
Can you follow this PR up and split these
There was a problem hiding this comment.
The thinking is the planner decides how to implement including when to write unit and cypress tests and we can use an expensive model like Opus to do that and the sub implementation agents can be run through sonnet which is cheaper. It also means these agents don't think but always expect a clear implementation plan to execute.
This branch was previously deployed
2 participants
Summary
glific-cypressrepo into this repo'scypress/directory — this PR documents that move and the workflow going forward.README.mdcovering pre-requisites, running tests (yarn cy:open/yarn cy:run), lint/format scripts, CI workflows, and where to add/update specs.ui-implementerandui-consistency-revieweragents so new UI features get a corresponding Cypress spec undercypress/e2e/, and existing spec fixes/updates happen here rather than in a now-defunct separate repo.Summary by CodeRabbit
Documentation
Chores