feat: add design-system implementer and reviewer agents for UI feature development and compliance checks - #4084
Conversation
|
🚀 Deployed on https://deploy-preview-4084--glific-frontend.netlify.app |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughAdded Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4084 +/- ##
==========================================
+ Coverage 82.12% 82.14% +0.01%
==========================================
Files 345 345
Lines 15129 15129
Branches 3586 3586
==========================================
+ Hits 12425 12428 +3
+ Misses 1641 1639 -2
+ Partials 1063 1062 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Glific
|
||||||||||||||||||||||||||||
| Project |
Glific
|
| Branch Review |
design-system/agents
|
| Run status |
|
| Run duration | 07m 02s |
| Commit |
|
| Committer | Akansha Sakhre |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
32
|
| View all changes introduced in this branch ↗︎ | |
Adds ui-implementer and ui-consistency-reviewer subagents, a components/UI catalog, and wires the reviewer into make-branch-ready-for-review's Phase 2 for diffs touching containers/** or components/UI/**.
fcbc354 to
049b69c
Compare
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/agents/ui-consistency-reviewer.md:
- Around line 71-85: Update the fenced example block in the UI consistency
review template to include an explicit language identifier, using text or
markdown, while preserving the block’s existing content.
- Around line 23-25: Update the MUI layering rule in the reviewer instructions
to detect the entire `@mui/` import namespace, not just `@mui/material`. Apply the
same restriction to imports such as `@mui/icons-material`, `@mui/system`, and
`@mui/x-date-pickers`, while preserving the existing exceptions for
src/components/UI/** and src/config/theme.tsx.
- Line 11: Resolve the contradiction in the review output instructions by
updating the `Looks good` requirement to match the directive to skip praise:
remove the required section, or explicitly permit brief positive notes. Apply
the same correction to the corresponding instructions near the additional
referenced lines.
In `@src/components/UI/README.md`:
- Around line 7-16: Update the documentation references in the UI README: use
the full `.claude/agents/ui-consistency-reviewer.md` path and the
`src/components/UI/Form/` path, and ensure every quick-lookup link such as
`#dialogbox` and `#input` targets an existing heading or explicit anchor,
removing links that cannot be made valid.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: b1e6d120-1b05-45e2-8593-476714cbe414
📒 Files selected for processing (4)
.claude/agents/ui-consistency-reviewer.md.claude/agents/ui-implementer.md.claude/skills/make-branch-ready-for-review/SKILL.mdsrc/components/UI/README.md
- Clarify the "skip praise" vs "Looks good" section contradiction - Check the full @mui/* import namespace, not just @mui/material - Add language to the output-format fence (markdownlint MD040) - Fix broken doc-reference paths and remove non-resolving anchor links in the component catalog's quick-lookup table
…e development and compliance checks (#4084) ### Summary - Adds two subagents: ui-implementer (builds new UI reusing shared components/tokens, with design-fundamentals guidance) and ui-consistency-reviewer (checks MUI-layering/token/reinvention violations before push). - Adds src/components/UI/README.md, the component catalog both agents read. - Wires ui-consistency-reviewer into make-branch-ready-for-review's Phase 2 for diffs touching containers/**/components/UI/**. - 4 files, 336 lines, based directly on master — no dependency on the ci-checks or token-migration branches. How to use - Building UI: invoke ui-implementer when starting new feature work. - Before pushing: ui-consistency-reviewer runs automatically via /make-branch-ready-for-review for UI-touching diffs, or invoke it directly. Test plan - [x] Typecheck clean - [x] No ticket refs, no old agent names, no token files anywhere in the diff - [x] gh pr diff --name-only confirms exactly the 4 intended files <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Added guidance for building polished, accessible, and responsive interfaces with consistent interaction states. * Added a catalog of reusable UI components, including usage guidance, reuse expectations, and known gaps. * Added UI consistency checks for shared interface changes, including design-token usage, component reuse, and accessibility. * Documented requirements for complete loading, empty, and error states. * Updated review guidance to address blocking UI consistency issues before changes are ready for review. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Summary
How to use
Test plan
Summary by CodeRabbit