Skip to content

fix(warning): Fix the key extractor of issue screen #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alejandronanez merged 1 commit into from
Oct 22, 2017
Merged

fix(warning): Fix the key extractor of issue screen #539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 39 additions & 37 deletions src/issue/screens/issue.screen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,8 +274,8 @@ class Issue extends Component {
});
};

keyExtractor = item => {
return item.id;
keyExtractor = (item, index) => {
return index;
};

renderHeader = () => {
Expand Down Expand Up @@ -366,44 +366,46 @@ class Issue extends Component {

return (
<ViewContainer>
{isShowLoadingContainer &&
<LoadingContainer animating={isShowLoadingContainer} center />}
{isShowLoadingContainer && (
<LoadingContainer animating={isShowLoadingContainer} center />
)}

{!isPendingComments &&
!isPendingIssue &&
issue &&
<KeyboardAvoidingView
style={{ flex: 1 }}
behavior={'padding'}
keyboardVerticalOffset={Platform.select({
ios: 65,
android: -200,
})}
>
<FlatList
ref={ref => {
this.commentsList = ref;
}}
refreshing={isLoadingData}
onRefresh={this.getIssueInformation}
contentContainerStyle={{ flexGrow: 1 }}
ListHeaderComponent={this.renderHeader}
removeClippedSubviews={false}
data={conversation}
keyExtractor={this.keyExtractor}
renderItem={this.renderItem}
/>

<CommentInput
users={fullUsers}
userHasPushPermission={
navigation.state.params.userHasPushPermission
}
issueLocked={issue.locked}
locale={locale}
onSubmit={this.postComment}
/>
</KeyboardAvoidingView>}
issue && (
<KeyboardAvoidingView
style={{ flex: 1 }}
behavior={'padding'}
keyboardVerticalOffset={Platform.select({
ios: 65,
android: -200,
})}
>
<FlatList
ref={ref => {
this.commentsList = ref;
}}
refreshing={isLoadingData}
onRefresh={this.getIssueInformation}
contentContainerStyle={{ flexGrow: 1 }}
ListHeaderComponent={this.renderHeader}
removeClippedSubviews={false}
data={conversation}
keyExtractor={this.keyExtractor}
renderItem={this.renderItem}
/>

<CommentInput
users={fullUsers}
userHasPushPermission={
navigation.state.params.userHasPushPermission
}
issueLocked={issue.locked}
locale={locale}
onSubmit={this.postComment}
/>
</KeyboardAvoidingView>
)}

<ActionSheet
ref={o => {
Expand Down