Skip to content

fix(warning): Fix the key extractor of issue screen#539

Merged
alejandronanez merged 1 commit intogitpoint:masterfrom
chinesedfan:fix_reusekey
Oct 22, 2017
Merged

fix(warning): Fix the key extractor of issue screen#539
alejandronanez merged 1 commit intogitpoint:masterfrom
chinesedfan:fix_reusekey

Conversation

@chinesedfan
Copy link
Copy Markdown
Member

Before #438, data of FlatList only contained issue and comments. But now events are included, which have no field calls id. (I changed 2 lines and prettier did the rest. 😱 )

const conversation = !isPendingComments
  ? [issue, ...comments, ...events].sort(compareCreatedAt)
  : [];

Copy link
Copy Markdown
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

@alejandronanez alejandronanez merged commit fa4e4d2 into gitpoint:master Oct 22, 2017
@chinesedfan chinesedfan deleted the fix_reusekey branch October 22, 2017 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants