Consolidate RunSummary and DownloadResult analysis fields

[Copilot]

RunSummary and DownloadResult carried the same run-analysis field set independently, creating drift risk whenever artifact/log analysis metadata changed. This refactor moves the shared surface into one embedded type while preserving promoted field access and flat RunSummary JSON.

• Shared data model
  • Added RunAnalysis for the common run metadata, metrics, analysis reports, usage summaries, and job details.
  • Embedded RunAnalysis in both RunSummary and DownloadResult.
  • Kept PolicyAnalysis and ArtifactsList on RunSummary, where they remain summary-specific.

type RunAnalysis struct {
    Run                  WorkflowRun       `json:"run"`
    Metrics              LogMetrics        `json:"metrics"`
    AccessAnalysis       *DomainAnalysis   `json:"access_analysis"`
    FirewallAnalysis     *FirewallAnalysis `json:"firewall_analysis"`
    // ...
}

type RunSummary struct {
    CLIVersion  string    `json:"cli_version"`
    RunID       int64     `json:"run_id"`
    ProcessedAt time.Time `json:"processed_at"`
    RunAnalysis
    PolicyAnalysis *PolicyAnalysis `json:"policy_analysis,omitempty"`
    ArtifactsList  []string        `json:"artifacts_list"`
}

type DownloadResult struct {
    RunAnalysis
    Error    error
    Skipped  bool
    Cached   bool
    LogsPath string
}

• Construction sites

  • Updated summary/result literals to initialize RunAnalysis.
  • Reused cached summary.RunAnalysis directly when converting a cached summary into a DownloadResult.

• Regression coverage

  • Added reflection-based coverage to ensure both carrier structs embed RunAnalysis, do not redeclare shared fields, and continue promoting those fields.
  • Verified RunSummary marshals embedded analysis fields as flat JSON keys rather than nesting under RunAnalysis.

• Fixes [deep-report] Consolidate 14 duplicated fields between RunSummary and DownloadResult in pkg/cli/logs_models.go #52740

---

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 20.9 AIC · ⌖ 7.31 AIC · ⊞ 8.7K · ◷
_{Comment /souschef to run again}

[Copilot]

Pull request overview

Consolidates duplicated run-analysis fields into an embedded RunAnalysis model while preserving flat summary JSON.

Changes:

• Embeds RunAnalysis in RunSummary and DownloadResult.
• Updates construction and cache-conversion paths.
• Adds embedding, promotion, serialization, and regression coverage.

Show a summary per file

File	Description
pkg/cli/logs_models.go	Defines and embeds RunAnalysis.
pkg/cli/logs_run_processor.go	Updates result and summary construction.
pkg/cli/audit.go	Builds audit summaries with shared analysis.
pkg/cli/audit_diff.go	Updates partial diff summaries.
pkg/cli/logs_summary_test.go	Tests embedding and flat JSON.
pkg/cli/logs_summary_integration_test.go	Updates cache integration fixtures.
pkg/cli/logs_usage_activity_test.go	Updates usage fixtures.
pkg/cli/logs_run_processor_test.go	Updates processor fixtures.
pkg/cli/logs_parallel_test.go	Updates result fixtures.
pkg/cli/logs_orchestrator_filters_test.go	Updates filter fixtures.
pkg/cli/logs_cache_test.go	Updates cache fixtures.
pkg/cli/forecast_compliance_fixtures_formal_test.go	Updates formal round-trip fixture.
pkg/cli/audit_test.go	Updates audit fixtures.
pkg/cli/audit_evals_fallback_test.go	Updates eval fallback fixture.
pkg/cli/audit_diff_test.go	Updates audit-diff fixtures.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 15/15 changed files
• Comments generated: 1
• Review effort level: Balanced

[gh-aw-bot]

@copilot Quick triage for maintainer-ready follow-up:

Please refresh the branch if GitHub allows it and run the pr-finisher skill before handing this PR back to maintainers.

Current signal:

• no failed checks were listed in the compact candidate set
• no PR comments are present yet, so please leave a concise maintainer-facing status update after your next change set
• if any review thread or requested follow-up exists outside the visible compact context, close the loop in-thread on the latest head before handing back

Run context: https://github.com/github/gh-aw/actions/runs/31907553336

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 20.9 AIC · ⌖ 7.31 AIC · ⊞ 8.7K · ◷
_{Comment /souschef to run again}

[Copilot]

@copilot Quick triage for maintainer-ready follow-up:

Please refresh the branch if GitHub allows it and run the pr-finisher skill before handing this PR back to maintainers....

Ran the pr-finisher pass:

• ✅ Reviews — the one review thread (doc comment attached to the new RunAnalysis instead of RunSummary) is addressed: the cache-summary doc block is back on RunSummary and RunAnalysis now has its own short doc comment.
• ✅ Checks (local) — make agent-report-progress (fmt, lint of changed files, impacted unit tests, workflow lock sync) passes.
• ❓ Checks (CI) — agent pushes don't trigger workflows, so CI on the current head is unverified; no prior failed checks were present.
• ✅ Mergeable — branch is up to date with main (already merged), no conflicts.

Latest change is doc-comment only, no behavior change. CI needs a maintainer re-trigger before merge.

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.87.0