Description
RunSummary (pkg/cli/logs_models.go:225) and DownloadResult (pkg/cli/logs_models.go:252) share 14 identical fields (Run, Metrics, AwContext, TaskDomain, BehaviorFingerprint, AgenticAssessments, AccessAnalysis, FirewallAnalysis, RedactedDomainsAnalysis, MissingTools, MissingData, Noops, MCPFailures, SkillActivations, MCPToolUsage, TokenUsage, GitHubRateLimitUsage, JobDetails) verified directly in the current source. Two prior issues (#47387 "Extract shared RunAnalysis base struct" and #47439 "Consolidate ... near-duplicate carrier structs") were filed for this and both closed, but the duplication is still present in main.
Expected Impact
Extracting a shared embedded struct (e.g. RunAnalysis) removes the duplication, reduces the risk of the two types drifting out of sync when a new field is added to only one, and shrinks logs_models.go.
Suggested Agent
Any code-quality/refactor agent. Note: this has been attempted twice before and closed without landing - worth checking why (e.g. a prior PR was abandoned) before re-attempting the same approach.
Estimated Effort
Medium (1-4 hours) - touches two structs and their many construction sites.
Data Source
DeepReport Intelligence Briefing analysis run 2026-08-14, surfaced by discussion #52704 (typist), source-verified against current main.
Generated by 🔬 Deep Report · agent · 279.4 AIC · ⌖ 53.2 AIC · ⊞ 11.4K · ◷
Description
RunSummary(pkg/cli/logs_models.go:225) andDownloadResult(pkg/cli/logs_models.go:252) share 14 identical fields (Run,Metrics,AwContext,TaskDomain,BehaviorFingerprint,AgenticAssessments,AccessAnalysis,FirewallAnalysis,RedactedDomainsAnalysis,MissingTools,MissingData,Noops,MCPFailures,SkillActivations,MCPToolUsage,TokenUsage,GitHubRateLimitUsage,JobDetails) verified directly in the current source. Two prior issues (#47387 "Extract shared RunAnalysis base struct" and #47439 "Consolidate ... near-duplicate carrier structs") were filed for this and both closed, but the duplication is still present inmain.Expected Impact
Extracting a shared embedded struct (e.g.
RunAnalysis) removes the duplication, reduces the risk of the two types drifting out of sync when a new field is added to only one, and shrinkslogs_models.go.Suggested Agent
Any code-quality/refactor agent. Note: this has been attempted twice before and closed without landing - worth checking why (e.g. a prior PR was abandoned) before re-attempting the same approach.
Estimated Effort
Medium (1-4 hours) - touches two structs and their many construction sites.
Data Source
DeepReport Intelligence Briefing analysis run 2026-08-14, surfaced by discussion #52704 (typist), source-verified against current
main.