Skip to content

Mitigate mcp/memory scan findings by removing container usage and pin references #51752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 6 commits into from
Aug 10, 2026
Merged

Mitigate mcp/memory scan findings by removing container usage and pin references #51752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7b626f2
Initial plan
Copilot Aug 10, 2026
5bf23f9
Exclude vulnerable mcp/memory image and migrate server-memory to uvx
Copilot Aug 10, 2026
2d24ec8
Remove server-memory MCP workflow component entirely
Copilot Aug 10, 2026
f0327a6
Merge remote-tracking branch 'origin/main' into copilot/container-ima…
Copilot Aug 10, 2026
eaa8602
Resolve MCP memory review feedback
Copilot Aug 10, 2026
1c89797
Merge remote-tracking branch 'origin/main' into copilot/container-ima…
Copilot Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/aw/actions-lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,11 +215,6 @@
"digest": "sha256:1174e6a29634a83b2be93ac1fefabf63265f498c02c72201fe3464e687dd8836",
"pinned_image": "mcp/context7@sha256:1174e6a29634a83b2be93ac1fefabf63265f498c02c72201fe3464e687dd8836"
},
"mcp/memory": {
"image": "mcp/memory",
"digest": "sha256:db0c2db07a44b6797eba7a832b1bda142ffc899588aae82c92780cbb2252407f",
"pinned_image": "mcp/memory@sha256:db0c2db07a44b6797eba7a832b1bda142ffc899588aae82c92780cbb2252407f"
},
"node:lts-alpine": {
"image": "node:lts-alpine",
"digest": "sha256:d32cdf619f63fe0471182d08996dd516c6275bb5fd31ae06e55a570bd9e1ad43",
Expand Down
55 changes: 15 additions & 40 deletions .github/workflows/mcp-inspector.lock.yml
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion .github/workflows/mcp-inspector.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ imports:
# Note: markitdown.md excluded — docker.io/mcp/markitdown has Critical/High CVEs (see #49515)
- shared/mcp/microsoft-docs.md
# Note: notion.md excluded — docker.io/mcp/notion has Critical/High CVEs (see #49517)
# Note: server-memory.md removed — mcp/memory has Critical/High CVEs and license violations (see #51716)
- shared/mcp/sentry.md

Copilot AI Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in eaa8602 by adding the server-memory.md removal note to .github/workflows/mcp-inspector.md, updating cache-memory.md so it no longer references the deleted shared import, and removing remaining vulnerable container examples/pins.

- shared/mcp/server-memory.md
- shared/mcp/slack.md
- shared/mcp/tavily.md
- shared/mcp/serena-go.md
Expand Down
65 changes: 0 additions & 65 deletions .github/workflows/shared/mcp/server-memory.md
View file
Open in desktop

This file was deleted.

7 changes: 2 additions & 5 deletions docs/src/content/docs/reference/cache-memory.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,19 +66,16 @@ tools:

Mounts at `/tmp/gh-aw/cache-memory/` (default) or `/tmp/gh-aw/cache-memory-{id}/`. The `id` determines the folder name; `key` defaults to a workflow-scoped prefix derived from the sanitized workflow name.

## Merging from Shared Workflows
## Using with MCP Servers

```aw wrap
---
imports:
- shared/mcp/server-memory.md

tools:
cache-memory: true
---
```

Merge rules: **Single→Single** (local overrides), **Single→Multiple** (local converts to array), **Multiple→Multiple** (merge by `id`, local wins).
MCP servers can persist temporary state by reading and writing files under `/tmp/gh-aw/cache-memory/` when `tools.cache-memory` is enabled. Configure the server directly in the workflow and point it at a subdirectory such as `/tmp/gh-aw/cache-memory/<server-name>/`.

## Behavior

Expand Down
5 changes: 0 additions & 5 deletions pkg/actionpins/data/action_pins.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,11 +215,6 @@
"digest": "sha256:1174e6a29634a83b2be93ac1fefabf63265f498c02c72201fe3464e687dd8836",
"pinned_image": "mcp/context7@sha256:1174e6a29634a83b2be93ac1fefabf63265f498c02c72201fe3464e687dd8836"
},
"mcp/memory": {
"image": "mcp/memory",
"digest": "sha256:db0c2db07a44b6797eba7a832b1bda142ffc899588aae82c92780cbb2252407f",
"pinned_image": "mcp/memory@sha256:db0c2db07a44b6797eba7a832b1bda142ffc899588aae82c92780cbb2252407f"
},
"node:lts-alpine": {
"image": "node:lts-alpine",
"digest": "sha256:d32cdf619f63fe0471182d08996dd516c6275bb5fd31ae06e55a570bd9e1ad43",
Expand Down
8 changes: 4 additions & 4 deletions pkg/parser/schemas/mcp_config_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@
"allowed": ["*"]
},
{
"container": "mcp/memory",
"entrypointArgs": ["-v", "/tmp/gh-aw/cache-memory:/app/dist"],
"allowed": ["store_memory", "retrieve_memory", "list_memories"]
"container": "ghcr.io/example/mcp-server:latest",
"entrypointArgs": ["stdio"],
"allowed": ["example_tool"]
}
],
"properties": {
Expand Down Expand Up @@ -67,7 +67,7 @@
"type": "string",
"pattern": "^[a-zA-Z0-9][a-zA-Z0-9/:_.-]*$",
"description": "Container image for stdio MCP connections (alternative to command)",
"examples": ["docker.io/mcp/brave-search", "mcp/memory", "ghcr.io/github/github-mcp-server:latest"]
"examples": ["docker.io/mcp/brave-search", "ghcr.io/example/mcp-server:latest", "ghcr.io/github/github-mcp-server:latest"]
},
"args": {
"type": "array",
Expand Down
5 changes: 0 additions & 5 deletions pkg/workflow/data/action_pins.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,11 +215,6 @@
"digest": "sha256:1174e6a29634a83b2be93ac1fefabf63265f498c02c72201fe3464e687dd8836",
"pinned_image": "mcp/context7@sha256:1174e6a29634a83b2be93ac1fefabf63265f498c02c72201fe3464e687dd8836"
},
"mcp/memory": {
"image": "mcp/memory",
"digest": "sha256:db0c2db07a44b6797eba7a832b1bda142ffc899588aae82c92780cbb2252407f",
"pinned_image": "mcp/memory@sha256:db0c2db07a44b6797eba7a832b1bda142ffc899588aae82c92780cbb2252407f"
},
"node:lts-alpine": {
"image": "node:lts-alpine",
"digest": "sha256:d32cdf619f63fe0471182d08996dd516c6275bb5fd31ae06e55a570bd9e1ad43",
Expand Down
Loading