Mitigate mcp/memory scan findings by removing container usage and pin references - #51752
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
mcp/memory scan findings by removing container usage and pin references
|
@copilot remove usage of this mcp all together |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot resolve the merge conflicts on this branch. |
There was a problem hiding this comment.
Pull request overview
Mitigates #51716 by removing the vulnerable mcp/memory container reference.
Changes:
- Removes the shared memory-server configuration and inspector import.
- Removes the image from pin catalogs.
- Regenerates the inspector lock workflow.
Show a summary per file
| File | Description |
|---|---|
.github/aw/actions-lock.json |
Removes the vulnerable image pin. |
.github/workflows/mcp-inspector.md |
Excludes the memory server import. |
.github/workflows/mcp-inspector.lock.yml |
Regenerates output without the container. |
.github/workflows/shared/mcp/server-memory.md |
Deletes the shared memory configuration. |
pkg/actionpins/data/action_pins.json |
Removes the action-pin catalog entry. |
pkg/workflow/data/action_pins.json |
Removes the workflow catalog entry. |
Review details
Tip
Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Suppressed comments (1)
.github/workflows/shared/mcp/server-memory.md:1
- Deleting this shared configuration instead of replacing its frontmatter removes the memory service entirely.
docs/src/content/docs/reference/cache-memory.md:74still tells users to import this path, and missing imports are hard compilation errors (pkg/parser/import_error_integration_test.go:47-59). Restore this file with theuvx/mcp-memory-serviceconfiguration described in the PR so the documented shared import remains usable without the vulnerable container.
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Balanced
| @@ -44,7 +44,6 @@ imports: | |||
| - shared/mcp/microsoft-docs.md | |||
| # Note: notion.md excluded — docker.io/mcp/notion has Critical/High CVEs (see #49517) | |||
| - shared/mcp/sentry.md | |||
There was a problem hiding this comment.
Addressed in eaa8602 by adding the server-memory.md removal note to .github/workflows/mcp-inspector.md, updating cache-memory.md so it no longer references the deleted shared import, and removing remaining vulnerable container examples/pins.
|
@copilot resolve the merge conflicts on this branch. |
…ge-scan-fix-vulnerabilities # Conflicts: # .github/workflows/mcp-inspector.lock.yml Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Resolved in f0327a6 by merging
Resolved in f0327a6 by merging |
|
@copilot PR sous-chef triage: please refresh the current maintainer-facing state on the latest head, resolve any addressed unresolved review threads, refresh the branch if GitHub can update it cleanly, and run the Open review context (newest first):
No failed checks were listed in the compact candidate snapshot.
|
Triage: Mitigate
|
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Completed in eaa8602. I refreshed against |
|
@copilot resolve the merge conflicts on this branch. |
|
@copilot resolve the merge conflicts on this branch. |
…ge-scan-fix-vulnerabilities # Conflicts: # .github/aw/actions-lock.json # .github/workflows/mcp-inspector.lock.yml # pkg/actionpins/data/action_pins.json # pkg/workflow/data/action_pins.json Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Resolved in |
|
🎉 This pull request is included in a new release. Release: |
The issue reported critical/high vulnerabilities and license violations in the pinned
mcp/memorycontainer image used by workflow MCP configuration. This change removes active usage of that image and eliminates it from pinned container catalogs consumed by workflow compilation.Workflow usage changes
shared/mcp/server-memory.mdno longer usescontainer: "mcp/memory".uvx-launched MCP memory service with explicit persisted storage path under cache-memory.mcp-inspector.mdexcludesserver-memory.mdfrom inspection imports with a security note tied to the vulnerability report.Pinned image catalog cleanup
mcp/memoryfrom.github/aw/actions-lock.json.pkg/actionpins/data/action_pins.jsonpkg/workflow/data/action_pins.jsonmcp-inspector.lock.ymlso the vulnerable image is no longer present in compiled workflow container sets.Run: https://github.com/github/gh-aw/actions/runs/31386523734> Generated by 👨🍳 PR Sous Chef · gpt54 · 15.8 AIC · ⌖ 7.79 AIC · ⊞ 6.1K · ◷