Skip to content

Revert "Upgrade from node16 to node20"#1053

Merged
Nishnha merged 1 commit into
mainfrom
revert-1050-nishnha/use-node-20
Sep 22, 2023
Merged

Revert "Upgrade from node16 to node20"#1053
Nishnha merged 1 commit into
mainfrom
revert-1050-nishnha/use-node-20

Conversation

@Nishnha
Copy link
Copy Markdown
Member

@Nishnha Nishnha commented Sep 22, 2023

Reverts #1050

Seeing an issue with finding the right node version on our action runners

System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter ''using: node20' is not supported, use 'docker', 'node12' or 'node16' instead.')

@Nishnha Nishnha requested a review from a team as a code owner September 22, 2023 15:23
@Nishnha
Copy link
Copy Markdown
Member Author

Nishnha commented Sep 22, 2023

The latest version of the actions runner ships with node20. Not sure how we can use that newer actions runner though: https://github.com/actions/runner/releases/tag/v2.308.0

@Nishnha Nishnha merged commit c2682a4 into main Sep 22, 2023
@Nishnha Nishnha deleted the revert-1050-nishnha/use-node-20 branch September 22, 2023 15:30
@honeyankit honeyankit mentioned this pull request Sep 26, 2023
@chenrui333
Copy link
Copy Markdown

@Nishnha you should probably do a sdk update as well. Let me put a PR to try the nodejs 20 upgrade again.

seeing the warning in the brew action run, https://github.com/Homebrew/brew/actions/runs/8911315184

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: github/dependabot-action@main. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants