Upgrade from node16 to node20#1050
Merged
Merged
Conversation
Member
|
We need to update .nvmrc too. |
node16 is now EOL
Nishnha
force-pushed
the
nishnha/use-node-20
branch
from
ea70ef8 to
373e1cb
Compare
Nishnha
force-pushed
the
nishnha/use-node-20
branch
from
373e1cb to
a299e5f
Compare
jakecoffman
approved these changes
Sep 21, 2023
Member
Author
|
It looks like the integration test in https://github.com/github/dependabot-action/actions/runs/6266275183/job/17018392140?pr=1050 ran successfully, but it somehow got stuck? It ran for ~2 hours before I cancelled it. I am also able to reproduce this on my machine by running It seems we have open handles preventing jest from closing and we should investigate them in a separate issue. I ended up committing 69be760 as a patch to quick fix this, since it seems to be a well known bug that jest can just hang when using the |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node16 is now EOL. The next LTS release is node18 which has support until 2025, but node20 has support until 2026.
https://nodejs.dev/en/about/releases/