Repository navigation
Revert "vulkan: Introduce driver version check for Windows Intel GPU to mitigate crashing (#25192)" - #26998
Closed
rillomas wants to merge 1 commit into
Closed
Revert "vulkan: Introduce driver version check for Windows Intel GPU to mitigate crashing (#25192)"#26998rillomas wants to merge 1 commit into
rillomas wants to merge 1 commit into
Conversation
…to mitigate crashing (ggml-org#25192)" This reverts commit eb41d50.
github-actions
Bot
added
Vulkan
Contributor
Author
|
Hi @0cc4m can you have a look? My bad on the testing part. |
Contributor
Author
|
Closing for a formal fix at #27049 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit eb41d50.
Overview
Temporary workaround for #26769. Turns out I didn't test thoroughly enough causing crashes on Xe Arc Graphics with older drivers.
I probably need to carve out just the Arc Graphics (UHD graphics and older Xe iGPU were OK) or gate both Xe1 and Xe2+GPUs, though may need more testing for the best approach.
Additional information
Requirements