Repository navigation
Conversation
llama.cpp.git/common/common.h:867:6: error: ‘ifstream’ in namespace ‘std’ does not name a type
867 | std::ifstream fs_open_ifstream(const std::string & fname, std::ios_base::openmode mode);
| ^~~~~~~~
llama.cpp.git/common/common.h:17:1: note: ‘std::ifstream’ is defined in header ‘<fstream>’; this is probably fixable by adding ‘#include <fstream>’
16 | #include <algorithm>
+++ |+#include <fstream>
17 |
With the upcoming GCC 17, C++ headers are cleaned up further and include
less unnecessary headers. fstream needs to be included here now.
|
Hi @wgottwalt, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
llama.cpp.git/common/common.h:867:6: error: ‘ifstream’ in namespace ‘std’ does not name a type
867 | std::ifstream fs_open_ifstream(const std::string & fname, std::ios_base::openmode mode);
| ^~~~~~~~
llama.cpp.git/common/common.h:17:1: note: ‘std::ifstream’ is defined in header ‘’; this is probably fixable by adding ‘#include ’
16 | #include
+++ |+#include
17 |
With the upcoming GCC 17, C++ headers are cleaned up further and include less unnecessary headers. fstream needs to be included here now.