Repository navigation
common : add missing <fstream> include in common.h - #25220
Conversation
Signed-off-by: zhangrunda <zhangrunda1234@outlook.com>
|
Hi @zhangrunda, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
Thanks for the note. To clarify: this is a one-line change (adding a missing |
Signed-off-by: zhangrunda <zhangrunda1234@outlook.com>
Signed-off-by: zhangrunda <zhangrunda1234@outlook.com>
Signed-off-by: zhangrunda <zhangrunda1234@outlook.com>
Overview
common/common.hdeclaresfs_open_ifstream()which returnsstd::ifstream, but the header does not#include <fstream>.The type was previously available only transitively through other includes.
On stricter toolchains (e.g. GCC trunk on aarch64/Graviton4) that transitive include is not present, so compilation fails with:error: 'ifstream' in namespace 'std' does not name a type
This adds the
#include <fstream>, following the include-what-you-use principle.Additional information
Fixes #25046
Requirements